From 06a0b2df6735b69bac034f6157bd1da70c33357b Mon Sep 17 00:00:00 2001 From: Seth Hall Date: Thu, 30 Jun 2011 14:24:15 -0400 Subject: [PATCH] Fixed a segfault from empty strings in the SSL analyzer. --- src/ssl-analyzer.pac | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/ssl-analyzer.pac b/src/ssl-analyzer.pac index 91e798e2bc..1f948aa893 100644 --- a/src/ssl-analyzer.pac +++ b/src/ssl-analyzer.pac @@ -45,13 +45,11 @@ function to_string_val(data : uint8[]) : StringVal %{ - if ( data->size() > 32 ) - return new StringVal(""); - char tmp[32]; memset(tmp, 0, sizeof(tmp)); - if ( data ) + // Just return an empty string if the string is longer than 32 bytes + if ( data && data->size() <= 32) { for ( unsigned int i = data->size(); i > 0; --i ) tmp[i-1] = (*data)[i-1];