From 0a0884edb433db295ef3ea44a2d64604b5d72d9b Mon Sep 17 00:00:00 2001
From: Max Kellermann <max.kellermann@gmail.com>
Date: Wed, 19 Feb 2020 13:13:43 +0100
Subject: [PATCH] Expr: fix memory leak in RecordConstructorExpr::InitVal()

---
 src/Expr.cc | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/Expr.cc b/src/Expr.cc
index 9fd5856d01..7d3794f04e 100644
--- a/src/Expr.cc
+++ b/src/Expr.cc
@@ -3142,12 +3142,10 @@ Val* RecordConstructorExpr::InitVal(const BroType* t, Val* aggr) const
 		{
 		RecordVal* rv = v->AsRecordVal();
 		RecordVal* ar = rv->CoerceTo(t->AsRecordType(), aggr);
+		Unref(rv);
 
 		if ( ar )
-			{
-			Unref(rv);
 			return ar;
-			}
 		}
 
 	Error("bad record initializer");