From 0d62ed478338c7c27d32acee05fa60d77af28703 Mon Sep 17 00:00:00 2001 From: Tim Wojtulewicz Date: Wed, 3 Mar 2021 10:29:11 -0700 Subject: [PATCH] Use const-reference in plugin::Manager::MetaHookPost for minor performance gain --- src/plugin/Manager.cc | 2 +- src/plugin/Manager.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugin/Manager.cc b/src/plugin/Manager.cc index 4d1f35d9e4..d629455dae 100644 --- a/src/plugin/Manager.cc +++ b/src/plugin/Manager.cc @@ -942,7 +942,7 @@ void Manager::MetaHookPre(HookType hook, const HookArgumentList& args) const plugin->MetaHookPre(hook, args); } -void Manager::MetaHookPost(HookType hook, const HookArgumentList& args, HookArgument result) const +void Manager::MetaHookPost(HookType hook, const HookArgumentList& args, const HookArgument& result) const { if ( hook_list* l = hooks[HOOK_CALL_FUNCTION] ) for ( const auto& [hook_type, plugin] : *l ) diff --git a/src/plugin/Manager.h b/src/plugin/Manager.h index 5882b018bd..c97a411304 100644 --- a/src/plugin/Manager.h +++ b/src/plugin/Manager.h @@ -414,7 +414,7 @@ private: bool ActivateDynamicPluginInternal(const std::string& name, bool ok_if_not_found, std::vector* errors); void UpdateInputFiles(); void MetaHookPre(HookType hook, const HookArgumentList& args) const; - void MetaHookPost(HookType hook, const HookArgumentList& args, HookArgument result) const; + void MetaHookPost(HookType hook, const HookArgumentList& args, const HookArgument& result) const; // Plugins that were explicitly requested to be activated, but failed to // load at first.