From 0ef315d143cf123c824ffebeea5ab0c70de7827a Mon Sep 17 00:00:00 2001 From: Jon Siwek Date: Mon, 8 Mar 2021 12:39:39 -0800 Subject: [PATCH] Add explicit return value to Reducer::SameOp() Helps tools that don't realize the implications of [[noreturn]] on the Reporter::InternalError() in this case. --- src/script_opt/Reduce.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/script_opt/Reduce.cc b/src/script_opt/Reduce.cc index aa58cf20fc..bfb53f4aa2 100644 --- a/src/script_opt/Reduce.cc +++ b/src/script_opt/Reduce.cc @@ -224,8 +224,8 @@ bool Reducer::SameOp(const Expr* op1, const Expr* op2) return true; } - else - reporter->InternalError("bad singleton tag"); + reporter->InternalError("bad singleton tag"); + return false; } bool Reducer::SameExpr(const Expr* e1, const Expr* e2)