diff --git a/src/DNS_Mgr.cc b/src/DNS_Mgr.cc index e89dbf7d2f..2491ff39ff 100644 --- a/src/DNS_Mgr.cc +++ b/src/DNS_Mgr.cc @@ -46,13 +46,13 @@ extern int select(int, fd_set *, fd_set *, fd_set *, struct timeval *); class DNS_Mgr_Request { public: - DNS_Mgr_Request(const char* h) { host = copy_string(h); addr = 0; } - DNS_Mgr_Request(uint32 a) { addr = a; host = 0; } + DNS_Mgr_Request(const char* h) { host = copy_string(h); } + DNS_Mgr_Request(const IPAddr& a) { addr = a; host = 0; } ~DNS_Mgr_Request() { delete [] host; } // Returns nil if this was an address request. const char* ReqHost() const { return host; } - uint32 ReqAddr() const { return addr; } + const IPAddr& ReqAddr() const { return addr; } int MakeRequest(nb_dns_info* nb_dns); int RequestPending() const { return request_pending; } @@ -61,7 +61,7 @@ public: protected: char* host; // if non-nil, this is a host request - uint32 addr; + IPAddr addr; uint32 ttl; int request_pending; }; @@ -77,13 +77,18 @@ int DNS_Mgr_Request::MakeRequest(nb_dns_info* nb_dns) if ( host ) return nb_dns_host_request(nb_dns, host, (void*) this, err) >= 0; else - return nb_dns_addr_request(nb_dns, addr, (void*) this, err) >= 0; + { + const uint32* bytes; + int len = addr.GetBytes(&bytes); + return nb_dns_addr_request2(nb_dns, (char*) bytes, + len == 1 ? AF_INET : AF_INET6, (void*) this, err) >= 0; + } } class DNS_Mapping { public: DNS_Mapping(const char* host, struct hostent* h, uint32 ttl); - DNS_Mapping(uint32 addr, struct hostent* h, uint32 ttl); + DNS_Mapping(const IPAddr& addr, struct hostent* h, uint32 ttl); DNS_Mapping(FILE* f); int NoMapping() const { return no_mapping; } @@ -93,11 +98,10 @@ public: // Returns nil if this was an address request. const char* ReqHost() const { return req_host; } - uint32 ReqAddr() const { return req_addr; } + const IPAddr& ReqAddr() const { return req_addr; } const char* ReqStr() const { - return req_host ? req_host : - string(IPAddr(IPAddr::IPv4, &req_addr, IPAddr::Network)).c_str(); + return req_host ? req_host : string(req_addr).c_str(); } ListVal* Addrs(); @@ -124,7 +128,7 @@ protected: int init_failed; char* req_host; - uint32 req_addr; + IPAddr req_addr; uint32 req_ttl; int num_names; @@ -132,7 +136,7 @@ protected: StringVal* host_val; int num_addrs; - uint32* addrs; + IPAddr* addrs; ListVal* addrs_val; int failed; @@ -157,14 +161,13 @@ DNS_Mapping::DNS_Mapping(const char* host, struct hostent* h, uint32 ttl) { Init(h); req_host = copy_string(host); - req_addr = 0; req_ttl = ttl; if ( names && ! names[0] ) names[0] = copy_string(host); } -DNS_Mapping::DNS_Mapping(uint32 addr, struct hostent* h, uint32 ttl) +DNS_Mapping::DNS_Mapping(const IPAddr& addr, struct hostent* h, uint32 ttl) { Init(h); req_addr = addr; @@ -178,7 +181,6 @@ DNS_Mapping::DNS_Mapping(FILE* f) init_failed = 1; req_host = 0; - req_addr = 0; char buf[512]; @@ -200,10 +202,7 @@ DNS_Mapping::DNS_Mapping(FILE* f) else { string s(req_buf); - IPAddr addr(s); - const uint32* bytes; - addr.GetBytes(&bytes); - req_addr = *bytes; //FIXME: IPv6 support + req_addr = IPAddr(s); } num_names = 1; @@ -212,7 +211,7 @@ DNS_Mapping::DNS_Mapping(FILE* f) if ( num_addrs > 0 ) { - addrs = new uint32[num_addrs]; + addrs = new IPAddr[num_addrs]; for ( int i = 0; i < num_addrs; ++i ) { @@ -227,10 +226,7 @@ DNS_Mapping::DNS_Mapping(FILE* f) *newline = '\0'; string s(buf); - IPAddr addr(s); - const uint32* bytes; - addr.GetBytes(&bytes); - addrs[i] = *bytes; //FIXME IPv6 support + addrs[i] = IPAddr(s); } } else @@ -293,14 +289,6 @@ StringVal* DNS_Mapping::Host() return host_val; } -// Converts an array of 4 bytes in network order to the corresponding -// 32-bit network long. -static uint32 raw_bytes_to_addr(const unsigned char b[4]) - { - uint32 l = (b[0] << 24) | (b[1] << 16) | (b[2] << 8) | b[3]; - return uint32(htonl(l)); - } - void DNS_Mapping::Init(struct hostent* h) { no_mapping = 0; @@ -309,7 +297,7 @@ void DNS_Mapping::Init(struct hostent* h) host_val = 0; addrs_val = 0; - if ( ! h || h->h_addrtype != AF_INET || h->h_length != 4 ) + if ( ! h ) { Clear(); return; @@ -324,10 +312,14 @@ void DNS_Mapping::Init(struct hostent* h) if ( num_addrs > 0 ) { - addrs = new uint32[num_addrs]; + addrs = new IPAddr[num_addrs]; for ( int i = 0; i < num_addrs; ++i ) - addrs[i] = raw_bytes_to_addr( - (unsigned char*)h->h_addr_list[i]); + if ( h->h_addrtype == AF_INET ) + addrs[i] = IPAddr(IPAddr::IPv4, (uint32*)h->h_addr_list[i], + IPAddr::Network); + else if ( h->h_addrtype == AF_INET6 ) + addrs[i] = IPAddr(IPAddr::IPv6, (uint32*)h->h_addr_list[i], + IPAddr::Network); } else addrs = 0; @@ -349,14 +341,12 @@ void DNS_Mapping::Clear() void DNS_Mapping::Save(FILE* f) const { fprintf(f, "%.0f %d %s %d %s %d\n", creation_time, req_host != 0, - req_host ? req_host : - string(IPAddr(IPAddr::IPv4, &req_addr, IPAddr::Network)).c_str(), + req_host ? req_host : string(req_addr).c_str(), failed, (names && names[0]) ? names[0] : "*", num_addrs); for ( int i = 0; i < num_addrs; ++i ) - fprintf(f, "%s\n", - string(IPAddr(IPAddr::IPv4, &addrs[i], IPAddr::Network)).c_str()); + fprintf(f, "%s\n", string(addrs[i]).c_str()); } @@ -490,14 +480,14 @@ TableVal* DNS_Mgr::LookupHost(const char* name) } } -Val* DNS_Mgr::LookupAddr(uint32 addr) +Val* DNS_Mgr::LookupAddr(const IPAddr& addr) { if ( ! did_init ) Init(); if ( mode != DNS_PRIME ) { - HashKey h(&addr, 1); + HashKey h(addr); DNS_Mapping* d = addr_mappings.Lookup(&h); if ( d ) @@ -506,7 +496,7 @@ Val* DNS_Mgr::LookupAddr(uint32 addr) return d->Host(); else { - string s = IPAddr(IPAddr::IPv4, &addr, IPAddr::Network); + string s(addr); reporter->Warning("can't resolve IP address: %s", s.c_str()); return new StringVal(s.c_str()); } @@ -521,7 +511,7 @@ Val* DNS_Mgr::LookupAddr(uint32 addr) case DNS_FORCE: reporter->FatalError("can't find DNS entry for %s in cache", - string(IPAddr(IPAddr::IPv4, &addr, IPAddr::Network)).c_str()); + string(addr).c_str()); return 0; case DNS_DEFAULT: @@ -710,14 +700,12 @@ void DNS_Mgr::AddResult(DNS_Mgr_Request* dr, struct nb_dns_result* r) else { new_dm = new DNS_Mapping(dr->ReqAddr(), h, ttl); - uint32 tmp_addr = dr->ReqAddr(); - HashKey k(&tmp_addr, 1); + HashKey k(dr->ReqAddr()); prev_dm = addr_mappings.Insert(&k, new_dm); if ( new_dm->Failed() && prev_dm && prev_dm->Valid() ) { - uint32 tmp_addr = dr->ReqAddr(); - HashKey k2(&tmp_addr, 1); + HashKey k2(dr->ReqAddr()); (void) addr_mappings.Insert(&k2, prev_dm); ++keep_prev; } @@ -829,8 +817,7 @@ void DNS_Mgr::LoadCache(FILE* f) host_mappings.Insert(m->ReqHost(), m); else { - uint32 tmp_addr = m->ReqAddr(); - HashKey h(&tmp_addr, 1); + HashKey h(m->ReqAddr()); addr_mappings.Insert(&h, m); } } @@ -851,9 +838,9 @@ void DNS_Mgr::Save(FILE* f, PDict(DNS_Mapping)& m) dm->Save(f); } -const char* DNS_Mgr::LookupAddrInCache(dns_mgr_addr_type addr) +const char* DNS_Mgr::LookupAddrInCache(const IPAddr& addr) { - HashKey h(&addr, 1); + HashKey h(addr); DNS_Mapping* d = dns_mgr->addr_mappings.Lookup(&h); if ( ! d ) @@ -889,7 +876,7 @@ TableVal* DNS_Mgr::LookupNameInCache(string name) return d->AddrsSet(); } -void DNS_Mgr::AsyncLookupAddr(dns_mgr_addr_type host, LookupCallback* callback) +void DNS_Mgr::AsyncLookupAddr(const IPAddr& host, LookupCallback* callback) { if ( ! did_init ) Init(); @@ -999,7 +986,7 @@ double DNS_Mgr::NextTimestamp(double* network_time) return asyncs_timeouts.size() ? timer_mgr->Time() : -1.0; } -void DNS_Mgr::CheckAsyncAddrRequest(dns_mgr_addr_type addr, bool timeout) +void DNS_Mgr::CheckAsyncAddrRequest(const IPAddr& addr, bool timeout) { // Note that this code is a mirror of that for CheckAsyncHostRequest. diff --git a/src/DNS_Mgr.h b/src/DNS_Mgr.h index 91bcad4084..fb55b991cb 100644 --- a/src/DNS_Mgr.h +++ b/src/DNS_Mgr.h @@ -40,10 +40,6 @@ enum DNS_MgrMode { // Number of seconds we'll wait for a reply. #define DNS_TIMEOUT 5 -// ### For now, we don't support IPv6 lookups. When we do, this -// should become addr_type. -typedef uint32 dns_mgr_addr_type; - class DNS_Mgr : public IOSource { public: DNS_Mgr(DNS_MgrMode mode); @@ -56,7 +52,7 @@ public: // a set of addr. TableVal* LookupHost(const char* host); - Val* LookupAddr(uint32 addr); + Val* LookupAddr(const IPAddr& addr); // Define the directory where to store the data. void SetDir(const char* arg_dir) { dir = copy_string(arg_dir); } @@ -65,7 +61,7 @@ public: void Resolve(); int Save(); - const char* LookupAddrInCache(dns_mgr_addr_type addr); + const char* LookupAddrInCache(const IPAddr& addr); TableVal* LookupNameInCache(string name); // Support for async lookups. @@ -79,7 +75,7 @@ public: virtual void Timeout() = 0; }; - void AsyncLookupAddr(dns_mgr_addr_type host, LookupCallback* callback); + void AsyncLookupAddr(const IPAddr& host, LookupCallback* callback); void AsyncLookupName(string name, LookupCallback* callback); struct Stats { @@ -121,7 +117,7 @@ protected: // Finish the request if we have a result. If not, time it out if // requested. - void CheckAsyncAddrRequest(dns_mgr_addr_type addr, bool timeout); + void CheckAsyncAddrRequest(const IPAddr& addr, bool timeout); void CheckAsyncHostRequest(const char* host, bool timeout); // Process outstanding requests. @@ -164,7 +160,7 @@ protected: struct AsyncRequest { double time; - dns_mgr_addr_type host; + IPAddr host; string name; CallbackList callbacks; @@ -205,7 +201,7 @@ protected: }; - typedef map AsyncRequestAddrMap; + typedef map AsyncRequestAddrMap; AsyncRequestAddrMap asyncs_addrs; typedef map AsyncRequestNameMap; diff --git a/src/Hash.cc b/src/Hash.cc index 7873e398c3..c8e68da429 100644 --- a/src/Hash.cc +++ b/src/Hash.cc @@ -103,6 +103,16 @@ HashKey::HashKey(const BroString* s) is_our_dynamic = 0; } +HashKey::HashKey(const IPAddr& addr) + { + const uint32* bytes; + int len = addr.GetBytes(&bytes); + size = len * sizeof(uint32); + key = CopyKey(bytes, size); + is_our_dynamic = 1; + hash = HashBytes(key, size); + } + HashKey::HashKey(int copy_key, void* arg_key, int arg_size) { size = arg_size; diff --git a/src/Hash.h b/src/Hash.h index 00db53d075..2d24a05b79 100644 --- a/src/Hash.h +++ b/src/Hash.h @@ -6,6 +6,7 @@ #include #include "BroString.h" +#include "IPAddr.h" #define UHASH_KEY_SIZE 36 @@ -28,6 +29,7 @@ public: HashKey(const void* p); HashKey(const char* s); HashKey(const BroString* s); + HashKey(const IPAddr& addr); ~HashKey() { if ( is_our_dynamic ) diff --git a/src/bro.bif b/src/bro.bif index e5f5a6d6c3..bcd50edaf9 100644 --- a/src/bro.bif +++ b/src/bro.bif @@ -3432,25 +3432,7 @@ function lookup_addr%(host: addr%) : string frame->SetDelayed(); trigger->Hold(); - if ( host->AsAddr()->family() != IPAddr::IPv4 ) - { - // FIXME: This is a temporary work-around until we get this - // fixed. We warn the user once, and always trigger a timeout. - // Ticket #355 records the problem. - static bool warned = false; - if ( ! warned ) - { - reporter->Warning("lookup_addr() only supports IPv4 addresses currently"); - warned = true; - } - - trigger->Timeout(); - return 0; - } - - const uint32* bytes; - host->AsAddr()->GetBytes(&bytes); - dns_mgr->AsyncLookupAddr(*bytes, + dns_mgr->AsyncLookupAddr(*host->AsAddr(), new LookupHostCallback(trigger, frame->GetCall(), true)); return 0; %} diff --git a/src/nb_dns.c b/src/nb_dns.c index 475ba3b8b0..d3b3c5c4de 100644 --- a/src/nb_dns.c +++ b/src/nb_dns.c @@ -186,7 +186,7 @@ _nb_dns_cmpsockaddr(register struct sockaddr *sa1, #endif static const char serr[] = "answer from wrong nameserver (%d)"; - if (sa1->sa_family != sa1->sa_family) { + if (sa1->sa_family != sa2->sa_family) { snprintf(errstr, NB_DNS_ERRSIZE, serr, 1); return (-1); } @@ -381,7 +381,7 @@ nb_dns_addr_request2(register struct nb_dns_info *nd, char *addrp, size -= i; cp += i; } - snprintf(cp, size, "ip6.int"); + snprintf(cp, size, "ip6.arpa"); break; #endif