From 186fe346ad1c04a0047261e7d6f468aa85129633 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 23 Oct 2022 16:03:34 -0400 Subject: [PATCH] spelling: repetitions Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- scripts/base/init-bare.zeek | 3 ++- src/analyzer/protocol/snmp/snmp-analyzer.pac | 4 +++- testing/btest/Baseline/scripts.base.protocols.snmp.v2/out2 | 2 +- testing/scripts/snmp-test.zeek | 2 +- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/scripts/base/init-bare.zeek b/scripts/base/init-bare.zeek index 58b529e819..9b717365bc 100644 --- a/scripts/base/init-bare.zeek +++ b/scripts/base/init-bare.zeek @@ -4661,7 +4661,8 @@ export { type SNMP::BulkPDU: record { request_id: int; non_repeaters: count; - max_repititions: count; + max_repititions: count &deprecated="Remove in v6.1. Use max_repetitions instead"; + max_repetitions: count; bindings: SNMP::Bindings; }; } diff --git a/src/analyzer/protocol/snmp/snmp-analyzer.pac b/src/analyzer/protocol/snmp/snmp-analyzer.pac index 9ba78073c0..6291f39781 100644 --- a/src/analyzer/protocol/snmp/snmp-analyzer.pac +++ b/src/analyzer/protocol/snmp/snmp-analyzer.pac @@ -195,7 +195,9 @@ zeek::RecordValPtr build_bulk_pdu(const GetBulkRequestPDU* pdu) rv->Assign(0, asn1_integer_to_val(pdu->request_id(), zeek::TYPE_INT)); rv->Assign(1, asn1_integer_to_val(pdu->non_repeaters(), zeek::TYPE_COUNT)); rv->Assign(2, asn1_integer_to_val(pdu->max_repetitions(), zeek::TYPE_COUNT)); - rv->Assign(3, build_bindings(pdu->var_bindings())); + // Remove in v6.1: Misspelled repititions/repetitions backwards compat + rv->Assign(3, asn1_integer_to_val(pdu->max_repetitions(), zeek::TYPE_COUNT)); + rv->Assign(4, build_bindings(pdu->var_bindings())); return rv; } %} diff --git a/testing/btest/Baseline/scripts.base.protocols.snmp.v2/out2 b/testing/btest/Baseline/scripts.base.protocols.snmp.v2/out2 index e1cafd14b3..fb5bd0af4b 100644 --- a/testing/btest/Baseline/scripts.base.protocols.snmp.v2/out2 +++ b/testing/btest/Baseline/scripts.base.protocols.snmp.v2/out2 @@ -5,7 +5,7 @@ snmp_get_bulk_request [community=] request_id: 1817072941 non_repeaters: 0 - max_repititions: 0 + max_repetitions: 0 oid: 1.3.6.1.2.1.1.5.0 value (tag=0x05): snmp_response diff --git a/testing/scripts/snmp-test.zeek b/testing/scripts/snmp-test.zeek index 399935db4c..de9070fc76 100644 --- a/testing/scripts/snmp-test.zeek +++ b/testing/scripts/snmp-test.zeek @@ -87,7 +87,7 @@ function print_snmp_bulk_pdu(pdu: SNMP::BulkPDU) { print fmt(" request_id: %s", pdu$request_id); print fmt(" non_repeaters: %s", pdu$non_repeaters); - print fmt(" max_repititions: %s", pdu$max_repititions); + print fmt(" max_repetitions: %s", pdu$max_repetitions); print_snmp_bindings(pdu$bindings); }