From 1f7580db65822d6a27919a6bf31bdaf6496f7da8 Mon Sep 17 00:00:00 2001
From: Jon Siwek <jsiwek@corelight.com>
Date: Mon, 1 Feb 2021 18:06:19 -0800
Subject: [PATCH] Change LambdaExpr::OuterIDs() accessor to return
 const-reference

---
 src/Expr.h               | 2 +-
 src/script_opt/GenRDs.cc | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Expr.h b/src/Expr.h
index f422fc0df0..05771d956a 100644
--- a/src/Expr.h
+++ b/src/Expr.h
@@ -1302,7 +1302,7 @@ public:
 	LambdaExpr(std::unique_ptr<function_ingredients> ingredients,
 	           IDPList outer_ids);
 
-	IDPList OuterIDs() const	{ return outer_ids; }
+	const IDPList& OuterIDs() const	{ return outer_ids; }
 
 	ValPtr Eval(Frame* f) const override;
 	TraversalCode Traverse(TraversalCallback* cb) const override;
diff --git a/src/script_opt/GenRDs.cc b/src/script_opt/GenRDs.cc
index 2645323b08..5979be09ba 100644
--- a/src/script_opt/GenRDs.cc
+++ b/src/script_opt/GenRDs.cc
@@ -1126,7 +1126,7 @@ TraversalCode RD_Decorate::PreExpr(const Expr* e)
 	case EXPR_LAMBDA:
 		{
 		auto l = dynamic_cast<const LambdaExpr*>(e);
-		auto ids = l->OuterIDs();
+		const auto& ids = l->OuterIDs();
 
 		for ( auto& id : ids )
 			CheckVar(e, id, false);