From 24071118eb06d6fd25d27ccca258a8c2ac857f83 Mon Sep 17 00:00:00 2001
From: Benjamin Bannier <benjamin.bannier@corelight.com>
Date: Fri, 9 May 2025 09:12:32 +0200
Subject: [PATCH] Fix clang-tidy `bugprone-inc-dec-in-conditions` report in
 Spicy plugins glue compiler

---
 src/spicy/spicyz/glue-compiler.cc | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/spicy/spicyz/glue-compiler.cc b/src/spicy/spicyz/glue-compiler.cc
index a796ae51c9..8e14b70ef2 100644
--- a/src/spicy/spicyz/glue-compiler.cc
+++ b/src/spicy/spicyz/glue-compiler.cc
@@ -38,12 +38,8 @@ static std::string::size_type looking_at(const std::string& chunk, std::string::
                                          const std::string_view& token) {
     eat_spaces(chunk, &i);
 
-    for ( char j : token ) {
-        if ( i >= chunk.size() || chunk[i++] != j )
-            return 0;
-    }
-
-    return i;
+    bool token_at_position = i < chunk.size() && token == std::string_view(chunk).substr(i, token.size());
+    return token_at_position ? i + token.size() : 0;
 }
 
 static void eat_token(const std::string& chunk, std::string::size_type* i, const std::string_view& token) {