From 4c6c89d8636b249041bdaabbaaaa7b83154295b6 Mon Sep 17 00:00:00 2001 From: Tim Wojtulewicz Date: Mon, 2 Oct 2023 14:13:49 -0700 Subject: [PATCH 1/2] CI: Remove sanitizers resource template This template was added when the sanitizer builds needed more memory than all of the other builds. We've since increased the amount of memory that the other builds use beyond what's requested in this template, so it doesn't make sense to keep it around. --- .cirrus.yml | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index 306917691b..9536cedf70 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -44,13 +44,6 @@ freebsd_environment: &FREEBSD_ENVIRONMENT ZEEK_CI_CPUS: 8 ZEEK_CI_BTEST_JOBS: 8 -sanitizers_resource_template: &SANITIZERS_RESOURCE_TEMPLATE - cpu: 4 - # Sanitizers uses a lot more memory than a typical config. - memory: 12GB - # For greediness, see https://medium.com/cirruslabs/introducing-greedy-container-instances-29aad06dc2b4 - greedy: true - builds_only_if_template: &BUILDS_ONLY_IF_TEMPLATE # Rules for skipping builds: # - Do not run builds for anything that's cron triggered @@ -405,7 +398,7 @@ asan_sanitizer_task: container: # Just uses a recent/common distro to run memory error/leak checks. dockerfile: ci/ubuntu-20.04/Dockerfile - << : *SANITIZERS_RESOURCE_TEMPLATE + << : *RESOURCES_TEMPLATE << : *CI_TEMPLATE test_fuzzers_script: ./ci/test-fuzzers.sh @@ -420,7 +413,7 @@ ubsan_sanitizer_task: container: # Just uses a recent/common distro to run undefined behavior checks. dockerfile: ci/ubuntu-20.04/Dockerfile - << : *SANITIZERS_RESOURCE_TEMPLATE + << : *RESOURCES_TEMPLATE << : *CI_TEMPLATE << : *SKIP_TASK_ON_PR @@ -436,7 +429,7 @@ ubsan_sanitizer_task: # container: # # Just uses a recent/common distro to run memory error/leak checks. # dockerfile: ci/ubuntu-22.04/Dockerfile -# << : *SANITIZERS_RESOURCE_TEMPLATE +# << : *RESOURCES_TEMPLATE # << : *CI_TEMPLATE # << : *SKIP_TASK_ON_PR From bbf7f34cdc532da4a8fcdc72b8b12afa4f0fdd9c Mon Sep 17 00:00:00 2001 From: Tim Wojtulewicz Date: Mon, 2 Oct 2023 14:20:51 -0700 Subject: [PATCH 2/2] CI: Disable spicy on arm_debian11 and opensuse_leap_15_4 builds These two builds are struggling to complete due to OOM issues. Reducing the number of CPUs didn't help, so this temporarily disables Spicy from building on those hosts to reduce the memory usage. --- .cirrus.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.cirrus.yml b/.cirrus.yml index 9536cedf70..572d5182e9 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -11,6 +11,7 @@ btest_retries: &BTEST_RETRIES 2 memory: &MEMORY 16GB config: &CONFIG --build-type=release --disable-broker-tests --prefix=$CIRRUS_WORKING_DIR/install --ccache +no_spicy_config: &NO_SPICY_CONFIG --build-type=release --disable-broker-tests --disable-spicy --prefix=$CIRRUS_WORKING_DIR/install --ccache static_config: &STATIC_CONFIG --build-type=release --disable-broker-tests --enable-static-broker --enable-static-binpac --prefix=$CIRRUS_WORKING_DIR/install --ccache asan_sanitizer_config: &ASAN_SANITIZER_CONFIG --build-type=debug --disable-broker-tests --sanitizers=address --enable-fuzzers --enable-coverage --disable-spicy --ccache ubsan_sanitizer_config: &UBSAN_SANITIZER_CONFIG --build-type=debug --disable-broker-tests --sanitizers=undefined --enable-fuzzers --disable-spicy --ccache @@ -225,6 +226,8 @@ arm_debian11_task: dockerfile: ci/debian-11/Dockerfile << : *RESOURCES_TEMPLATE << : *CI_TEMPLATE + env: + ZEEK_CI_CONFIGURE_FLAGS: *NO_SPICY_CONFIG debian11_static_task: container: @@ -251,6 +254,8 @@ opensuse_leap_15_4_task: << : *RESOURCES_TEMPLATE << : *CI_TEMPLATE << : *SKIP_TASK_ON_PR + env: + ZEEK_CI_CONFIGURE_FLAGS: *NO_SPICY_CONFIG opensuse_leap_15_5_task: container: