From 2bc320cf119474326f0c89323741b048942c94ab Mon Sep 17 00:00:00 2001 From: Arne Welzel Date: Mon, 16 Jun 2025 18:18:43 +0200 Subject: [PATCH] IOSource: Remove IsPacketSource This wasn't used in tree and even the PktSrc class doesn't override this to return true, so just remove it outright without deprecation. Closes #4573 --- NEWS | 3 +++ src/iosource/IOSource.h | 5 ----- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/NEWS b/NEWS index a760d948cd..a28285dae8 100644 --- a/NEWS +++ b/NEWS @@ -48,6 +48,9 @@ Breaking Changes redef EventMetadata::add_missing_remote_network_timestamp = T; +- The ``IsPacketSource()`` method on ``IOSource`` was removed. It was unused + and incorrectly returned ``false`` on all packet sources. + New Functionality ----------------- diff --git a/src/iosource/IOSource.h b/src/iosource/IOSource.h index 599b4a4c7e..60f2abd896 100644 --- a/src/iosource/IOSource.h +++ b/src/iosource/IOSource.h @@ -32,11 +32,6 @@ public: */ bool IsOpen() const { return ! closed; } - /** - * Returns true if this is a packet source. - */ - virtual bool IsPacketSource() const { return false; } - /** * Initializes the source. Can be overwritten by derived classes. */