From 32fe94f0f839c5f3d3bb7af4f604d8e426b69166 Mon Sep 17 00:00:00 2001 From: Tim Wojtulewicz Date: Mon, 3 Jun 2024 09:35:20 -0700 Subject: [PATCH] Fix a memory leak with the CivetWeb callbacks in telemetry --- src/telemetry/Manager.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/telemetry/Manager.cc b/src/telemetry/Manager.cc index 0fedde48e0..a5a0ac872d 100644 --- a/src/telemetry/Manager.cc +++ b/src/telemetry/Manager.cc @@ -66,6 +66,9 @@ void Manager::InitPostScript() { try { prometheus_exposer = std::make_unique(prometheus_url, 2, callbacks); + + // CivetWeb stores a copy of the callbacks, so we're safe to delete the pointer here + delete callbacks; } catch ( const CivetException& exc ) { reporter->FatalError("Failed to setup Prometheus endpoint: %s\n", exc.what()); }