From ac776b0aadcdfd79fc3ac7b7e0fe12fef3f7ec41 Mon Sep 17 00:00:00 2001 From: Arne Welzel Date: Wed, 6 Aug 2025 13:13:38 +0200 Subject: [PATCH 1/2] btest/plugins/tap-analyzer: Update baseline Relates to #4337 #4725 #4734 --- .../Baseline/plugins.tap-analyzer/output | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/testing/btest/Baseline/plugins.tap-analyzer/output b/testing/btest/Baseline/plugins.tap-analyzer/output index c6516b9e1c..c658e4feb7 100644 --- a/testing/btest/Baseline/plugins.tap-analyzer/output +++ b/testing/btest/Baseline/plugins.tap-analyzer/output @@ -2,7 +2,7 @@ <...>/ip4-tcp-bad-chksum.pcap Init() uid=HhAvVGS1DHFjwGM9 Analyzer added to HhAvVGS1DHFjwGM9 -Packet(len=54 orig=1, action=1 skip_reason=1) uid=HhAvVGS1DHFjwGM9 +Packet(len=54 orig=1, action=1 skip_reason=2) uid=HhAvVGS1DHFjwGM9 Done() uid=HhAvVGS1DHFjwGM9 === <...>/ip4-tcp-good-chksum.pcap @@ -14,7 +14,7 @@ Done() uid=HhAvVGS1DHFjwGM9 <...>/ip4-udp-bad-chksum.pcap Init() uid=HhAvVGS1DHFjwGM9 Analyzer added to HhAvVGS1DHFjwGM9 -Packet(len=46 orig=1, action=1 skip_reason=1) uid=HhAvVGS1DHFjwGM9 +Packet(len=46 orig=1, action=1 skip_reason=2) uid=HhAvVGS1DHFjwGM9 Done() uid=HhAvVGS1DHFjwGM9 === <...>/ip4-udp-good-chksum.pcap @@ -26,7 +26,7 @@ Done() uid=HhAvVGS1DHFjwGM9 <...>/ip4-icmp-bad-chksum.pcap Init() uid=HhAvVGS1DHFjwGM9 Analyzer added to HhAvVGS1DHFjwGM9 -Packet(len=42 orig=1, action=1 skip_reason=1) uid=HhAvVGS1DHFjwGM9 +Packet(len=42 orig=1, action=1 skip_reason=2) uid=HhAvVGS1DHFjwGM9 Done() uid=HhAvVGS1DHFjwGM9 === <...>/ip4-icmp-good-chksum.pcap @@ -38,7 +38,7 @@ Done() uid=HhAvVGS1DHFjwGM9 <...>/ip6-icmp6-bad-chksum.pcap Init() uid=HhAvVGS1DHFjwGM9 Analyzer added to HhAvVGS1DHFjwGM9 -Packet(len=69 orig=1, action=1 skip_reason=1) uid=HhAvVGS1DHFjwGM9 +Packet(len=69 orig=1, action=1 skip_reason=2) uid=HhAvVGS1DHFjwGM9 Done() uid=HhAvVGS1DHFjwGM9 === <...>/ip6-icmp6-good-chksum.pcap @@ -73,15 +73,15 @@ Packet(len=78 orig=1, action=0 skip_reason=0) uid=HhAvVGS1DHFjwGM9 Packet(len=74 orig=0, action=0 skip_reason=0) uid=HhAvVGS1DHFjwGM9 Packet(len=66 orig=1, action=0 skip_reason=0) uid=HhAvVGS1DHFjwGM9 Packet(len=202 orig=1, action=0 skip_reason=0) uid=HhAvVGS1DHFjwGM9 -Packet(len=66 orig=0, action=1 skip_reason=3) uid=HhAvVGS1DHFjwGM9 -Packet(len=1514 orig=0, action=1 skip_reason=3) uid=HhAvVGS1DHFjwGM9 -Packet(len=1514 orig=0, action=1 skip_reason=3) uid=HhAvVGS1DHFjwGM9 -Packet(len=1514 orig=0, action=1 skip_reason=3) uid=HhAvVGS1DHFjwGM9 -Packet(len=729 orig=0, action=1 skip_reason=3) uid=HhAvVGS1DHFjwGM9 -Packet(len=66 orig=1, action=1 skip_reason=3) uid=HhAvVGS1DHFjwGM9 -Packet(len=66 orig=1, action=1 skip_reason=3) uid=HhAvVGS1DHFjwGM9 -Packet(len=66 orig=1, action=1 skip_reason=3) uid=HhAvVGS1DHFjwGM9 -Packet(len=66 orig=0, action=1 skip_reason=3) uid=HhAvVGS1DHFjwGM9 -Packet(len=66 orig=1, action=1 skip_reason=3) uid=HhAvVGS1DHFjwGM9 +Packet(len=66 orig=0, action=1 skip_reason=4) uid=HhAvVGS1DHFjwGM9 +Packet(len=1514 orig=0, action=1 skip_reason=4) uid=HhAvVGS1DHFjwGM9 +Packet(len=1514 orig=0, action=1 skip_reason=4) uid=HhAvVGS1DHFjwGM9 +Packet(len=1514 orig=0, action=1 skip_reason=4) uid=HhAvVGS1DHFjwGM9 +Packet(len=729 orig=0, action=1 skip_reason=4) uid=HhAvVGS1DHFjwGM9 +Packet(len=66 orig=1, action=1 skip_reason=4) uid=HhAvVGS1DHFjwGM9 +Packet(len=66 orig=1, action=1 skip_reason=4) uid=HhAvVGS1DHFjwGM9 +Packet(len=66 orig=1, action=1 skip_reason=4) uid=HhAvVGS1DHFjwGM9 +Packet(len=66 orig=0, action=1 skip_reason=4) uid=HhAvVGS1DHFjwGM9 +Packet(len=66 orig=1, action=1 skip_reason=4) uid=HhAvVGS1DHFjwGM9 Done() uid=HhAvVGS1DHFjwGM9 === From ce7c394af17c9e62f50d08f3f9c06c0d392647a9 Mon Sep 17 00:00:00 2001 From: Arne Welzel Date: Wed, 6 Aug 2025 14:19:30 +0200 Subject: [PATCH 2/2] TapAnalyzer: Fix docstring Relates to #4337 #4725 #4734 --- src/packet_analysis/protocol/ip/SessionAdapter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/packet_analysis/protocol/ip/SessionAdapter.h b/src/packet_analysis/protocol/ip/SessionAdapter.h index f42b8974f0..d26be5482a 100644 --- a/src/packet_analysis/protocol/ip/SessionAdapter.h +++ b/src/packet_analysis/protocol/ip/SessionAdapter.h @@ -183,7 +183,7 @@ public: * Remove a TapAnalyzer instance by raw pointer. * * Note that the TapAnalyzer instance \a ta is pointing at will be destroyed - * during the call to RemoveTapAanalyzer() and should be discarded by the caller + * during the call to RemoveTapAnalyzer() and should be discarded by the caller * immediately. If you call RemoveTapAnalyzer() from within a TapAnalyzer's member * function, ensure not accessing \a this afterwards. *