From 01e5de82341b41dd18b48f7a5d17ca4291c45fe1 Mon Sep 17 00:00:00 2001 From: Vlad Grigorescu Date: Wed, 18 Mar 2015 13:31:12 -0400 Subject: [PATCH] DNS: Log the type number for the DNS_RR_unknown_type weird. --- src/analyzer/protocol/dns/DNS.cc | 2 +- .../scripts.base.protocols.dns.duplicate-reponses/weird.log | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/analyzer/protocol/dns/DNS.cc b/src/analyzer/protocol/dns/DNS.cc index e551351926..378fe449b6 100644 --- a/src/analyzer/protocol/dns/DNS.cc +++ b/src/analyzer/protocol/dns/DNS.cc @@ -308,7 +308,7 @@ int DNS_Interpreter::ParseAnswer(DNS_MsgInfo* msg, analyzer->ConnectionEvent(dns_unknown_reply, vl); } - analyzer->Weird("DNS_RR_unknown_type"); + analyzer->Weird("DNS_RR_unknown_type", fmt("%d", msg->atype)); data += rdlength; len -= rdlength; status = 1; diff --git a/testing/btest/Baseline/scripts.base.protocols.dns.duplicate-reponses/weird.log b/testing/btest/Baseline/scripts.base.protocols.dns.duplicate-reponses/weird.log index 295de4ec2c..0592a777db 100644 --- a/testing/btest/Baseline/scripts.base.protocols.dns.duplicate-reponses/weird.log +++ b/testing/btest/Baseline/scripts.base.protocols.dns.duplicate-reponses/weird.log @@ -3,10 +3,10 @@ #empty_field (empty) #unset_field - #path weird -#open 2014-02-13-20-36-35 +#open 2015-03-18-17-30-43 #fields ts uid id.orig_h id.orig_p id.resp_h id.resp_p name addl notice peer #types time string addr port addr port string string bool string -1363716396.798286 CXWv6p3arKYeMETxOg 55.247.223.174 27285 222.195.43.124 53 DNS_RR_unknown_type - F bro +1363716396.798286 CXWv6p3arKYeMETxOg 55.247.223.174 27285 222.195.43.124 53 DNS_RR_unknown_type 46 F bro 1363716396.798374 CXWv6p3arKYeMETxOg 55.247.223.174 27285 222.195.43.124 53 dns_unmatched_reply - F bro 1363716396.798374 - - - - - dns_unmatched_msg - F bro -#close 2014-02-13-20-36-35 +#close 2015-03-18-17-30-44