From 3ba671ab3a9e1a513d6cd9f720bdd94da77b31f9 Mon Sep 17 00:00:00 2001 From: Daniel Thayer Date: Thu, 28 Jan 2016 14:32:22 -0600 Subject: [PATCH] Fix portability issue with use of mktemp Some platforms require six Xs in the mktemp template. --- testing/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/testing/Makefile b/testing/Makefile index 122262f865..e83ec09396 100644 --- a/testing/Makefile +++ b/testing/Makefile @@ -17,8 +17,8 @@ make-brief: coverage: @for repo in $(DIRS); do (cd $$repo && echo "Coverage for '$$repo' dir:" && make -s coverage); done - @test -f btest/coverage.log && cp btest/coverage.log `mktemp brocov.tmp.XXX` || true - @for f in external/*/coverage.log; do test -f $$f && cp $$f `mktemp brocov.tmp.XXX` || true; done + @test -f btest/coverage.log && cp btest/coverage.log `mktemp brocov.tmp.XXXXXX` || true + @for f in external/*/coverage.log; do test -f $$f && cp $$f `mktemp brocov.tmp.XXXXXX` || true; done @echo "Complete test suite code coverage:" @./scripts/coverage-calc "brocov.tmp.*" coverage.log `pwd`/../scripts @rm -f brocov.tmp.*