From 0470b065378674803ad5df577630b25a87392b6a Mon Sep 17 00:00:00 2001 From: Seth Hall Date: Wed, 23 Jun 2021 10:12:57 +0000 Subject: [PATCH 1/3] Load the builtin-plugin preload files and fix the dev path. --- src/zeek-setup.cc | 1 + zeek-path-dev.in | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/zeek-setup.cc b/src/zeek-setup.cc index 3a66f2a350..b34a54ea12 100644 --- a/src/zeek-setup.cc +++ b/src/zeek-setup.cc @@ -548,6 +548,7 @@ SetupResult setup(int argc, char** argv, Options* zopts) if ( ! options.bare_mode ) add_input_file("base/init-default.zeek"); + add_input_file("builtin-plugins/__preload__.zeek"); add_input_file("builtin-plugins/__load__.zeek"); plugin_mgr->SearchDynamicPlugins(util::zeek_plugin_path()); diff --git a/zeek-path-dev.in b/zeek-path-dev.in index fe70f6a4a1..bea0f21145 100755 --- a/zeek-path-dev.in +++ b/zeek-path-dev.in @@ -10,4 +10,4 @@ # ZEEKPATH=`./zeek-path-dev` ./src/zeek # -echo .:${CMAKE_SOURCE_DIR}/scripts:${CMAKE_SOURCE_DIR}/scripts/policy:${CMAKE_SOURCE_DIR}/scripts/site:${CMAKE_BINARY_DIR}/scripts +echo .:${CMAKE_SOURCE_DIR}/scripts:${CMAKE_SOURCE_DIR}/scripts/policy:${CMAKE_SOURCE_DIR}/scripts/site:${CMAKE_BINARY_DIR}/scripts:${CMAKE_BINARY_DIR}/scripts/builtin-plugins From adb8ee16cbc6d82e36e708139f19cc23663474bc Mon Sep 17 00:00:00 2001 From: Seth Hall Date: Wed, 23 Jun 2021 10:19:20 +0000 Subject: [PATCH 2/3] Removed a non-functional builtin plugin preload loading mechanism --- src/plugin/Manager.cc | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/plugin/Manager.cc b/src/plugin/Manager.cc index d9d750ebaf..40a9f99ff7 100644 --- a/src/plugin/Manager.cc +++ b/src/plugin/Manager.cc @@ -275,15 +275,6 @@ bool Manager::ActivateDynamicPluginInternal(const std::string& name, bool ok_if_ // First load {scripts}/__preload__.zeek automatically. init = dir + "scripts/__preload__.zeek"; - if ( util::is_file(init) ) - { - DBG_LOG(DBG_PLUGINS, " Loading %s", init.c_str()); - scripts_to_load.push_back(init); - } - - // First load {scripts}/__preload__.zeek automatically. - init = dir + "builtin-plugins/__preload__.zeek"; - if ( util::is_file(init) ) { DBG_LOG(DBG_PLUGINS, " Loading %s", init.c_str()); From 6c66f6ede55d9482530659631e9e19eef83c7060 Mon Sep 17 00:00:00 2001 From: Seth Hall Date: Wed, 30 Jun 2021 19:22:19 +0000 Subject: [PATCH 3/3] Fix tests --- .../coverage.bare-load-baseline/canonified_loaded_scripts.log | 1 + .../canonified_loaded_scripts.log | 1 + testing/btest/Baseline/plugins.hooks/output | 3 +++ 3 files changed, 5 insertions(+) diff --git a/testing/btest/Baseline/coverage.bare-load-baseline/canonified_loaded_scripts.log b/testing/btest/Baseline/coverage.bare-load-baseline/canonified_loaded_scripts.log index b7da253ba7..59555f5f80 100644 --- a/testing/btest/Baseline/coverage.bare-load-baseline/canonified_loaded_scripts.log +++ b/testing/btest/Baseline/coverage.bare-load-baseline/canonified_loaded_scripts.log @@ -230,6 +230,7 @@ scripts/base/init-frameworks-and-bifs.zeek build/scripts/base/bif/plugins/Zeek_AsciiWriter.ascii.bif.zeek build/scripts/base/bif/plugins/Zeek_NoneWriter.none.bif.zeek build/scripts/base/bif/plugins/Zeek_SQLiteWriter.sqlite.bif.zeek +build/scripts/builtin-plugins/__preload__.zeek build/scripts/builtin-plugins/__load__.zeek scripts/policy/misc/loaded-scripts.zeek scripts/base/utils/paths.zeek diff --git a/testing/btest/Baseline/coverage.default-load-baseline/canonified_loaded_scripts.log b/testing/btest/Baseline/coverage.default-load-baseline/canonified_loaded_scripts.log index 129dddecb2..9a26b43ba7 100644 --- a/testing/btest/Baseline/coverage.default-load-baseline/canonified_loaded_scripts.log +++ b/testing/btest/Baseline/coverage.default-load-baseline/canonified_loaded_scripts.log @@ -427,6 +427,7 @@ scripts/base/init-default.zeek scripts/base/misc/find-checksum-offloading.zeek scripts/base/misc/find-filtered-trace.zeek scripts/base/misc/version.zeek +build/scripts/builtin-plugins/__preload__.zeek build/scripts/builtin-plugins/__load__.zeek scripts/policy/misc/loaded-scripts.zeek #close XXXX-XX-XX-XX-XX-XX diff --git a/testing/btest/Baseline/plugins.hooks/output b/testing/btest/Baseline/plugins.hooks/output index dab6db4b7b..45fe311958 100644 --- a/testing/btest/Baseline/plugins.hooks/output +++ b/testing/btest/Baseline/plugins.hooks/output @@ -1013,6 +1013,7 @@ 0.000000 MetaHookPost LoadFile(0, base<...>/xmpp, <...>/xmpp) -> -1 0.000000 MetaHookPost LoadFile(0, base<...>/zeek.bif, <...>/zeek.bif.zeek) -> -1 0.000000 MetaHookPost LoadFile(0, builtin-plugins/__load__.zeek, <...>/__load__.zeek) -> -1 +0.000000 MetaHookPost LoadFile(0, builtin-plugins/__preload__.zeek, <...>/__preload__.zeek) -> -1 0.000000 MetaHookPost LoadFile(1, ./archive, <...>/archive.sig) -> -1 0.000000 MetaHookPost LoadFile(1, ./audio, <...>/audio.sig) -> -1 0.000000 MetaHookPost LoadFile(1, ./dpd.sig, <...>/dpd.sig) -> -1 @@ -2044,6 +2045,7 @@ 0.000000 MetaHookPre LoadFile(0, base<...>/xmpp, <...>/xmpp) 0.000000 MetaHookPre LoadFile(0, base<...>/zeek.bif, <...>/zeek.bif.zeek) 0.000000 MetaHookPre LoadFile(0, builtin-plugins/__load__.zeek, <...>/__load__.zeek) +0.000000 MetaHookPre LoadFile(0, builtin-plugins/__preload__.zeek, <...>/__preload__.zeek) 0.000000 MetaHookPre LoadFile(1, ./archive, <...>/archive.sig) 0.000000 MetaHookPre LoadFile(1, ./audio, <...>/audio.sig) 0.000000 MetaHookPre LoadFile(1, ./dpd.sig, <...>/dpd.sig) @@ -3086,6 +3088,7 @@ 0.000000 | HookLoadFile base<...>/xmpp <...>/xmpp 0.000000 | HookLoadFile base<...>/zeek.bif <...>/zeek.bif.zeek 0.000000 | HookLoadFile builtin-plugins/__load__.zeek <...>/__load__.zeek +0.000000 | HookLoadFile builtin-plugins/__preload__.zeek <...>/__preload__.zeek 0.000000 | HookLogInit packet_filter 1/1 {ts (time), node (string), filter (string), init (bool), success (bool)} 0.000000 | HookLogWrite packet_filter [ts=XXXXXXXXXX.XXXXXX, node=zeek, filter=ip or not ip, init=T, success=T] 0.000000 | HookQueueEvent NetControl::init()