From 4ad5d2031b5f06ec6f3a381e43ee088b265824a0 Mon Sep 17 00:00:00 2001
From: Johanna Amann <johanna@corelight.com>
Date: Wed, 30 Jun 2021 10:12:00 +0100
Subject: [PATCH] Fix memory leak in x509_check_cert_hostname bif

---
 src/file_analysis/analyzer/x509/functions.bif | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/file_analysis/analyzer/x509/functions.bif b/src/file_analysis/analyzer/x509/functions.bif
index af4f971099..95ee203e8b 100644
--- a/src/file_analysis/analyzer/x509/functions.bif
+++ b/src/file_analysis/analyzer/x509/functions.bif
@@ -1060,8 +1060,13 @@ function x509_check_cert_hostname%(cert_opaque: opaque of x509, hostname: string
 #endif
 			std::string_view nameview {name, len};
 			if ( check_hostname(hostview, nameview) )
-				return zeek::make_intrusive<zeek::StringVal>(len, name);
+				{
+				auto retval = zeek::make_intrusive<zeek::StringVal>(len, name);
+				GENERAL_NAMES_free(altname);
+				return retval;
+				}
 			}
+		GENERAL_NAMES_free(altname);
 		}
 	else
 		{