From 53c3d2032abc6796f9a5ce3c35cb28c09e92be9b Mon Sep 17 00:00:00 2001 From: Tim Wojtulewicz Date: Wed, 24 Apr 2024 12:08:48 -0700 Subject: [PATCH] Remove the is_sum argument from BIF histogram creation methods --- scripts/base/frameworks/telemetry/main.zeek | 3 +-- src/telemetry/telemetry.bif | 6 ++---- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/scripts/base/frameworks/telemetry/main.zeek b/scripts/base/frameworks/telemetry/main.zeek index f57024dd31..20795585a0 100644 --- a/scripts/base/frameworks/telemetry/main.zeek +++ b/scripts/base/frameworks/telemetry/main.zeek @@ -428,8 +428,7 @@ function register_histogram_family(opts: MetricOpts): HistogramFamily opts$labels, opts$bounds, opts$help_text, - opts$unit, - opts?$is_total ? opts$is_total : F + opts$unit ); return HistogramFamily($__family=f, $__labels=opts$labels); } diff --git a/src/telemetry/telemetry.bif b/src/telemetry/telemetry.bif index ac46a2e6d5..2e99648605 100644 --- a/src/telemetry/telemetry.bif +++ b/src/telemetry/telemetry.bif @@ -367,8 +367,7 @@ function Telemetry::__int_histogram_family%(prefix: string, labels: string_vec, bounds: int_vec, helptext: string &default = "Zeek Script Metric", - unit: string &default = "", - is_sum: bool &default = F%): opaque of int_histogram_metric_family + unit: string &default = ""%): opaque of int_histogram_metric_family %{ auto lbl_vec = sv_vec(labels->AsVectorVal()); auto std_bounds = to_std_vec(bounds); @@ -430,8 +429,7 @@ function Telemetry::__dbl_histogram_family%(prefix: string, labels: string_vec, bounds: double_vec, helptext: string &default = "Zeek Script Metric", - unit: string &default = "", - is_sum: bool &default = F%): opaque of dbl_histogram_metric_family + unit: string &default = ""%): opaque of dbl_histogram_metric_family %{ auto lbl_vec = sv_vec(labels->AsVectorVal()); auto std_bounds = to_std_vec(bounds);