diff --git a/CHANGES b/CHANGES index 62b103f7fc..317fbb1021 100644 --- a/CHANGES +++ b/CHANGES @@ -1,4 +1,13 @@ +2.5-551 | 2018-05-01 18:27:38 -0500 + + * Fix the ip-broken-header.bro test on macOS due to missing 'xzcat' + (Daniel Thayer) + + * Improve reliability of the logging rotate.bro test (Daniel Thayer) + + * Improve reliability of missing-file-initially.bro test (Daniel thayer) + 2.5-547 | 2018-05-01 18:17:14 -0500 * Update install instructions for Ubuntu 18.04 (Daniel Thayer) diff --git a/VERSION b/VERSION index 60705092ed..98f5b14c58 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -2.5-547 +2.5-551 diff --git a/testing/btest/Baseline/scripts.base.frameworks.input.missing-file-initially/bro..stdout b/testing/btest/Baseline/scripts.base.frameworks.input.missing-file-initially/bro..stdout index 39309bc8cf..3d47249011 100644 --- a/testing/btest/Baseline/scripts.base.frameworks.input.missing-file-initially/bro..stdout +++ b/testing/btest/Baseline/scripts.base.frameworks.input.missing-file-initially/bro..stdout @@ -1,5 +1,5 @@ -now it does -and more! -now it does -and more! -Streaming still works +input: now it does +input: and more! +inputstream: now it does +inputstream: and more! +inputstream: Streaming still works diff --git a/testing/btest/Traces/trunc/mpls-6in6-broken.pcap.gz b/testing/btest/Traces/trunc/mpls-6in6-broken.pcap.gz new file mode 100644 index 0000000000..af717b19c4 Binary files /dev/null and b/testing/btest/Traces/trunc/mpls-6in6-broken.pcap.gz differ diff --git a/testing/btest/Traces/trunc/mpls-6in6-broken.pcap.xz b/testing/btest/Traces/trunc/mpls-6in6-broken.pcap.xz deleted file mode 100644 index f45d0a9a17..0000000000 Binary files a/testing/btest/Traces/trunc/mpls-6in6-broken.pcap.xz and /dev/null differ diff --git a/testing/btest/core/ip-broken-header.bro b/testing/btest/core/ip-broken-header.bro index 48a90d2821..426e7a7bc0 100644 --- a/testing/btest/core/ip-broken-header.bro +++ b/testing/btest/core/ip-broken-header.bro @@ -1,7 +1,7 @@ # This test has a trace that was generated from fuzzing which used to cause # OOB reads in Bro. It has a number of packets broken in weird ways. # -# @TEST-EXEC: xzcat $TRACES/trunc/mpls-6in6-broken.pcap.xz | bro -C -b -r - %INPUT +# @TEST-EXEC: gunzip -c $TRACES/trunc/mpls-6in6-broken.pcap.gz | bro -C -b -r - %INPUT # @TEST-EXEC: btest-diff weird.log @load base/frameworks/notice/weird.bro diff --git a/testing/btest/scripts/base/frameworks/input/missing-file-initially.bro b/testing/btest/scripts/base/frameworks/input/missing-file-initially.bro index 4db255b69d..5b7baed4f9 100644 --- a/testing/btest/scripts/base/frameworks/input/missing-file-initially.bro +++ b/testing/btest/scripts/base/frameworks/input/missing-file-initially.bro @@ -4,8 +4,11 @@ # failing behavior. # @TEST-EXEC: btest-bg-run bro bro %INPUT -# @TEST-EXEC: sleep 2; cp does-exist.dat does-not-exist.dat -# @TEST-EXEC: sleep 2; mv does-not-exist.dat does-not-exist-again.dat; echo "Streaming still works" >> does-not-exist-again.dat +# @TEST-EXEC: sleep 10 +# @TEST-EXEC: mv does-exist.dat does-not-exist.dat +# @TEST-EXEC: sleep 2 +# @TEST-EXEC: mv does-not-exist.dat does-not-exist-again.dat +# @TEST-EXEC: echo "Streaming still works" >> does-not-exist-again.dat # @TEST-EXEC: btest-bg-wait -k 3 # @TEST-EXEC: btest-diff bro/.stdout # @TEST-EXEC: TEST_DIFF_CANONIFIER=$SCRIPTS/diff-sort btest-diff bro/.stderr @@ -30,7 +33,7 @@ type Val: record { event line(description: Input::EventDescription, tpe: Input::Event, v: Val) { - print v$line; + print fmt("%s: %s", description$name, v$line); } event line2(description: Input::EventDescription, tpe: Input::Event, v: Val) diff --git a/testing/btest/scripts/base/frameworks/logging/rotate.bro b/testing/btest/scripts/base/frameworks/logging/rotate.bro index 86f659c193..501c0db8ea 100644 --- a/testing/btest/scripts/base/frameworks/logging/rotate.bro +++ b/testing/btest/scripts/base/frameworks/logging/rotate.bro @@ -1,5 +1,6 @@ # -# @TEST-EXEC: bro -b -r ${TRACES}/rotation.trace %INPUT 2>&1 | grep "test" >out +# @TEST-EXEC: bro -b -r ${TRACES}/rotation.trace %INPUT >bro.out 2>&1 +# @TEST-EXEC: grep "test" bro.out | sort >out # @TEST-EXEC: for i in `ls test.*.log | sort`; do printf '> %s\n' $i; cat $i; done >>out # @TEST-EXEC: btest-diff out