From 6c0a9b0d8f4be8f42bbffa33e7c8628de19af85a Mon Sep 17 00:00:00 2001
From: Jon Siwek <jsiwek@corelight.com>
Date: Mon, 20 Apr 2020 14:43:06 -0700
Subject: [PATCH] Deprecate binpac::string_to_val

---
 NEWS             | 2 ++
 src/binpac_bro.h | 1 +
 2 files changed, 3 insertions(+)

diff --git a/NEWS b/NEWS
index 8974a62adc..2fb081aa1c 100644
--- a/NEWS
+++ b/NEWS
@@ -115,6 +115,8 @@ Deprecated Functionality
 
 - ``binpac::bytestring_to_val()`` is deprecated, use ``binpac::to_stringval()``.
 
+- ``binpac::string_to_val()`` is deprecated, use ``StringVal`` constructor.
+
 Zeek 3.1.0
 ==========
 
diff --git a/src/binpac_bro.h b/src/binpac_bro.h
index e921b68742..743bb7443d 100644
--- a/src/binpac_bro.h
+++ b/src/binpac_bro.h
@@ -23,6 +23,7 @@ typedef Val* BroVal;
 typedef PortVal* BroPortVal;
 typedef StringVal* BroStringVal;
 
+[[deprecated("Remove in v4.1.  Use StringVal constructor directly.")]]
 inline StringVal* string_to_val(string const &str)
 	{
 	return new StringVal(str.c_str());