From 766cc0d220ffaf3fd6f85588ef475700f33b79ed Mon Sep 17 00:00:00 2001 From: Jon Siwek Date: Thu, 5 Sep 2013 15:30:28 -0500 Subject: [PATCH] Fix mem leak when failing to end a serialization. We'd probably know about it if that actually ever happened in practice (which it shouldn't). --- src/Serializer.cc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Serializer.cc b/src/Serializer.cc index 683b543e48..145aab3f4d 100644 --- a/src/Serializer.cc +++ b/src/Serializer.cc @@ -70,12 +70,8 @@ bool Serializer::StartSerialization(SerialInfo* info, const char* descr, bool Serializer::EndSerialization(SerialInfo* info) { - ChunkedIO::Chunk* chunk = new ChunkedIO::Chunk; - chunk->len = format->EndWrite(&chunk->data); - if ( info->chunk ) { - if ( ! io->Write(info->chunk) ) { Error(io->Error()); @@ -83,6 +79,9 @@ bool Serializer::EndSerialization(SerialInfo* info) } } + ChunkedIO::Chunk* chunk = new ChunkedIO::Chunk; + chunk->len = format->EndWrite(&chunk->data); + if ( ! io->Write(chunk) ) { Error(io->Error());