From 782b4d0eae18f413e44eaf53804cd6167f6ab59c Mon Sep 17 00:00:00 2001 From: Jon Siwek Date: Tue, 2 Sep 2014 16:22:15 -0500 Subject: [PATCH] Change EDNS parsing code to use rdlength more cautiously. It shouldn't ever be negative, but if it were, using it to modify the data pointer/length isn't appropriate. --- src/analyzer/protocol/dns/DNS.cc | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/analyzer/protocol/dns/DNS.cc b/src/analyzer/protocol/dns/DNS.cc index 8f66d74857..e551351926 100644 --- a/src/analyzer/protocol/dns/DNS.cc +++ b/src/analyzer/protocol/dns/DNS.cc @@ -692,11 +692,6 @@ int DNS_Interpreter::ParseRR_EDNS(DNS_MsgInfo* msg, data += rdlength; len -= rdlength; } - else - { // no data, move on - data += rdlength; - len -= rdlength; - } return 1; }