From 7c5c36959f58cc3cd324583bd51f5d0498f6711d Mon Sep 17 00:00:00 2001 From: Dominik Charousset Date: Tue, 2 Mar 2021 08:20:49 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Jon Siwek --- src/Span.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Span.h b/src/Span.h index e78af1ab11..903b0c0c8b 100644 --- a/src/Span.h +++ b/src/Span.h @@ -157,7 +157,7 @@ public: return numElements; } - constexpr size_t numElementsbytes() const noexcept + constexpr size_t size_bytes() const noexcept { return numElements * sizeof(element_type); } @@ -174,9 +174,9 @@ public: // -- subviews ------------------------------------------------------------- - constexpr Span subspan(size_t offset, size_t num_bytes) const + constexpr Span subspan(size_t offset, size_t num_elements) const { - return {memoryBlock + offset, num_bytes}; + return {memoryBlock + offset, num_elements}; } constexpr Span subspan(size_t offset) const @@ -184,14 +184,14 @@ public: return {memoryBlock + offset, numElements - offset}; } - constexpr Span first(size_t num_bytes) const + constexpr Span first(size_t num_elements) const { - return {memoryBlock, num_bytes}; + return {memoryBlock, num_elements}; } - constexpr Span last(size_t num_bytes) const + constexpr Span last(size_t num_elements) const { - return subspan(numElements - num_bytes, num_bytes); + return subspan(numElements - num_elements, num_elements); } private: