From 7ec96f25acf7d2dfa890a08cd366515a55e6b8cb Mon Sep 17 00:00:00 2001
From: Tim Wojtulewicz <tim@corelight.com>
Date: Tue, 24 Mar 2020 13:11:26 -0700
Subject: [PATCH] Don't use xor operator for boolean operations

---
 src/Expr.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/Expr.cc b/src/Expr.cc
index 4df7b8485b..be49c740be 100644
--- a/src/Expr.cc
+++ b/src/Expr.cc
@@ -2053,7 +2053,8 @@ bool AssignExpr::TypeCheck(attr_list* attrs)
 		// the script level.
 		return true;
 
-	if ( ((bt1 == TYPE_ENUM) ^ (bt2 == TYPE_ENUM)) )
+	// This should be one of them, but not both (i.e. XOR)
+	if ( (bt1 == TYPE_ENUM) == ! (bt2 == TYPE_ENUM) )
 		{
 		ExprError("can't convert to/from enumerated type");
 		return false;