From 853f9bfea3262eda2a42f3b78ba9a6f242a7b49c Mon Sep 17 00:00:00 2001
From: Arne Welzel <arne.welzel@corelight.com>
Date: Thu, 15 Aug 2024 12:18:30 +0200
Subject: [PATCH] Type: CreationInitsOptimizer: PreTypedef() is not prone to
 endless recursion

---
 src/Type.cc | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/src/Type.cc b/src/Type.cc
index 402aee2505..f2c1f52953 100644
--- a/src/Type.cc
+++ b/src/Type.cc
@@ -969,11 +969,6 @@ class RecordType::CreationInitsOptimizer : public detail::TraversalCallback {
 public:
     detail::TraversalCode PreTypedef(const detail::ID* id) override {
         const auto& t = id->GetType();
-        if ( analyzed_types.count(t) > 0 )
-            return detail::TC_ABORTSTMT;
-
-        analyzed_types.emplace(t);
-
         if ( t->Tag() == TYPE_RECORD )
             OptimizeCreationInits(t->AsRecordType());
 
@@ -995,9 +990,6 @@ private:
         // Discard remaining elements.
         rt->creation_inits.resize(i);
     }
-
-    // Endless recursion avoidance.
-    std::unordered_set<TypePtr> analyzed_types;
 };
 
 RecordType::RecordType(type_decl_list* arg_types) : Type(TYPE_RECORD) {