diff --git a/CHANGES b/CHANGES index 9f26c845d4..b264d55877 100644 --- a/CHANGES +++ b/CHANGES @@ -1,4 +1,11 @@ +3.2.0-dev.798 | 2020-06-19 13:25:02 -0700 + + * Remove last_access_time from TableEntryVal. (Johanna Amann, Corelight) + + Turns out - this was no longer used. And it takes up at least 8 bytes + of space for every single table/set entry. + 3.2.0-dev.796 | 2020-06-18 20:40:59 +0000 * cmake: Make musl support more distro agnostic (Andrew Benson) diff --git a/VERSION b/VERSION index ff87f40023..30c4aee60c 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -3.2.0-dev.796 +3.2.0-dev.798 diff --git a/src/Val.cc b/src/Val.cc index 0823c56a70..7d0fbe610f 100644 --- a/src/Val.cc +++ b/src/Val.cc @@ -1307,7 +1307,6 @@ unsigned int ListVal::MemoryAllocation() const TableEntryVal* TableEntryVal::Clone(Val::CloneState* state) { auto rval = new TableEntryVal(val ? val->Clone(state) : nullptr); - rval->last_access_time = last_access_time; rval->expire_access_time = expire_access_time; return rval; } diff --git a/src/Val.h b/src/Val.h index 84afb01e51..d76d36d25a 100644 --- a/src/Val.h +++ b/src/Val.h @@ -722,7 +722,6 @@ public: explicit TableEntryVal(IntrusivePtr v) : val(std::move(v)) { - last_access_time = network_time; expire_access_time = int(network_time - bro_start_network_time); } @@ -745,8 +744,6 @@ protected: friend class TableVal; IntrusivePtr val; - double last_access_time; - // The next entry stores seconds since Bro's start. We use ints here // to save a few bytes, as we do not need a high resolution for these // anyway.