From 9a922d88b2033c9c3cc89557ef05cc45a4cdb8b7 Mon Sep 17 00:00:00 2001 From: Arne Welzel Date: Fri, 12 Jan 2024 12:21:40 +0100 Subject: [PATCH] Session/Conn: Follow-up fix for hist_seen and history lift Borked in commit b4e86f28b8adcbd45b9008dfa1818c6eb2fbb4d0. We don't need to initialize std::string explicitly either. Thanks coverity! --- src/Conn.cc | 3 --- src/session/Session.cc | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/Conn.cc b/src/Conn.cc index dc46e06f89..96d5571e50 100644 --- a/src/Conn.cc +++ b/src/Conn.cc @@ -58,9 +58,6 @@ Connection::Connection(const detail::ConnKey& k, double t, const ConnTuple* id, finished = 0; - hist_seen = 0; - history = ""; - adapter = nullptr; primary_PIA = nullptr; diff --git a/src/session/Session.cc b/src/session/Session.cc index 3d244e35f6..262abe1c3b 100644 --- a/src/session/Session.cc +++ b/src/session/Session.cc @@ -58,6 +58,7 @@ Session::Session(double t, EventHandlerPtr timeout_event, EventHandlerPtr status timers_canceled = 0; inactivity_timeout = 0; installed_status_timer = 0; + hist_seen = 0; } void Session::Event(EventHandlerPtr f, analyzer::Analyzer* analyzer, const char* name) {