From a2320ffe889d0f9600d515d0d4c093c22d56636c Mon Sep 17 00:00:00 2001 From: Yacin Nadji Date: Wed, 9 Mar 2022 11:15:48 -0500 Subject: [PATCH] Zero out bytes by default for consistent return value on error --- src/zeek.bif | 2 +- testing/btest/Baseline/bifs.raw_bytes_to_v6_addr/out | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/zeek.bif b/src/zeek.bif index db0af51ea1..1737349f1b 100644 --- a/src/zeek.bif +++ b/src/zeek.bif @@ -2731,7 +2731,7 @@ function raw_bytes_to_v4_addr%(b: string%): addr ## .. zeek:see:: raw_bytes_to_v6_addr to_addr to_subnet function raw_bytes_to_v6_addr%(x: string%): addr %{ - uint32_t bytes[4]; + uint32_t bytes[4] = {0, 0, 0, 0}; if ( x->Len() < 16 ) zeek::emit_builtin_error("too short a string as input to raw_bytes_to_v6_addr()"); diff --git a/testing/btest/Baseline/bifs.raw_bytes_to_v6_addr/out b/testing/btest/Baseline/bifs.raw_bytes_to_v6_addr/out index 31ab948f9b..059b996fd8 100644 --- a/testing/btest/Baseline/bifs.raw_bytes_to_v6_addr/out +++ b/testing/btest/Baseline/bifs.raw_bytes_to_v6_addr/out @@ -1,4 +1,4 @@ ### BTest baseline data generated by btest-diff. Do not edit. Use "btest -U/-u" to update. Requires BTest >= 0.63. 4142:4344:4546:4748:494b:4c4d:4e4f:5051 -2852:8180:ff7f:0:2700:: +:: dada:beef::4e5e:cff:fe6a:8671