From a84d06a2c367c5b226f4f3cd774f6216e542ed10 Mon Sep 17 00:00:00 2001 From: Robin Sommer Date: Thu, 6 Oct 2022 13:16:00 +0200 Subject: [PATCH] Suppress warning on an existing packet analyzer being remapped. There was a check generating an internal warning if a new packet analyzer mapping overwrote an existing one. However, replacing an existing analyzer with a new one seems a legitimate use case (and will be supported by Spicy soon). So removing that warning. --- src/packet_analysis/Dispatcher.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/packet_analysis/Dispatcher.cc b/src/packet_analysis/Dispatcher.cc index d06d8ec706..8c21254bb9 100644 --- a/src/packet_analysis/Dispatcher.cc +++ b/src/packet_analysis/Dispatcher.cc @@ -52,10 +52,6 @@ void Dispatcher::Register(uint32_t identifier, AnalyzerPtr analyzer) } int64_t index = identifier - lowest_identifier; - if ( table[index] != nullptr ) - reporter->InternalWarning("Overwriting packet analyzer mapping %#8" PRIx64 " => %s with %s", - index + lowest_identifier, table[index]->GetAnalyzerName(), - analyzer->GetAnalyzerName()); table[index] = std::move(analyzer); }