From ae2ff9901bbc241b5d1b2a6224118ad73c22ae9c Mon Sep 17 00:00:00 2001
From: Tim Wojtulewicz <tim@corelight.com>
Date: Thu, 17 Apr 2025 15:24:08 -0700
Subject: [PATCH] Fix clang-tidy bugprone-unsafe-functions warnings

---
 .clang-tidy        | 1 +
 src/DNS_Mapping.cc | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/.clang-tidy b/.clang-tidy
index cfe3c518f5..8d4e3ee2db 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -16,4 +16,5 @@ Checks: [-*,
          bugprone-suspicious-realloc-usage,
          bugprone-throw-keyword-missing,
          bugprone-unused-local-non-trivial-variable,
+         bugprone-unsafe-functions,
 ]
diff --git a/src/DNS_Mapping.cc b/src/DNS_Mapping.cc
index 2500551606..a1299974ec 100644
--- a/src/DNS_Mapping.cc
+++ b/src/DNS_Mapping.cc
@@ -300,17 +300,17 @@ TEST_CASE("dns_mapping save reload") {
     // Try loading from the file at EOF. This should cause a mapping failure.
     DNS_Mapping mapping(tmpfile);
     CHECK(mapping.NoMapping());
-    rewind(tmpfile);
+    fseek(tmpfile, 0, SEEK_SET);
 
     // Try reading from the empty file. This should cause an init failure.
     DNS_Mapping mapping2(tmpfile);
     CHECK(mapping2.InitFailed());
-    rewind(tmpfile);
+    fseek(tmpfile, 0, SEEK_SET);
 
     // Save a valid mapping into the file and rewind to the start.
     DNS_Mapping mapping3(addr, &he, 123);
     mapping3.Save(tmpfile);
-    rewind(tmpfile);
+    fseek(tmpfile, 0, SEEK_SET);
 
     // Test loading the mapping back out of the file
     DNS_Mapping mapping4(tmpfile);