From b3de432ef2c4f38dd4456eebe5c7fa12775d755c Mon Sep 17 00:00:00 2001 From: Tim Wojtulewicz Date: Thu, 17 Apr 2025 11:23:14 -0700 Subject: [PATCH] Fix clang-tidy bugprone-misplaced-widening-cast warnings --- .clang-tidy | 1 + src/file_analysis/analyzer/x509/X509.cc | 3 +++ 2 files changed, 4 insertions(+) diff --git a/.clang-tidy b/.clang-tidy index 5f1732ea4e..a74dd56327 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -7,4 +7,5 @@ Checks: [-*, bugprone-macro-parentheses, bugprone-multi-level-implicit-pointer-conversion, bugprone-inc-dec-in-conditions, + bugprone-misplaced-widening-cast, ] diff --git a/src/file_analysis/analyzer/x509/X509.cc b/src/file_analysis/analyzer/x509/X509.cc index 2dab26e25a..d1e80c1ae7 100644 --- a/src/file_analysis/analyzer/x509/X509.cc +++ b/src/file_analysis/analyzer/x509/X509.cc @@ -110,7 +110,10 @@ RecordValPtr X509::ParseCertificate(X509Val* cert_val, file_analysis::File* f) { auto pX509Cert = make_intrusive(BifType::Record::X509::Certificate); BIO* bio = BIO_new(BIO_s_mem()); + // The cast here is intentional to force it into a specific version of Assign() + // NOLINTNEXTLINE(bugprone-misplaced-widening-cast) pX509Cert->Assign(0, static_cast(X509_get_version(ssl_cert) + 1)); + i2a_ASN1_INTEGER(bio, X509_get_serialNumber(ssl_cert)); int len = BIO_read(bio, buf, sizeof(buf)); pX509Cert->Assign(1, make_intrusive(len, buf));