diff --git a/scripts/policy/frameworks/management/agent/main.zeek b/scripts/policy/frameworks/management/agent/main.zeek index a767c757fa..117dc3f1c9 100644 --- a/scripts/policy/frameworks/management/agent/main.zeek +++ b/scripts/policy/frameworks/management/agent/main.zeek @@ -40,7 +40,7 @@ redef record Management::Request::Request += { }; # Tag our logs correctly -redef Management::Log::role = Management::AGENT; +redef Management::role = Management::AGENT; # The global configuration as passed to us by the controller global g_config: Management::Configuration; diff --git a/scripts/policy/frameworks/management/config.zeek b/scripts/policy/frameworks/management/config.zeek index 7b87655ae5..6f59bbc6eb 100644 --- a/scripts/policy/frameworks/management/config.zeek +++ b/scripts/policy/frameworks/management/config.zeek @@ -5,9 +5,16 @@ ##! anyway). For role-specific settings, see management/controller/config.zeek ##! and management/agent/config.zeek. +@load ./types + module Management; export { + ## The role of this process in cluster management. Use this to + ## differentiate code based on the type of node in which it ends up + ## running. + const role = Management::NONE &redef; + ## The fallback listen address if more specific adddresses, such as ## the controller's :zeek:see:`Management::Controller::listen_address` ## remains empty. Unless redefined, this uses Broker's own default diff --git a/scripts/policy/frameworks/management/controller/main.zeek b/scripts/policy/frameworks/management/controller/main.zeek index b2f5c44711..f9d3c2d0a3 100644 --- a/scripts/policy/frameworks/management/controller/main.zeek +++ b/scripts/policy/frameworks/management/controller/main.zeek @@ -71,7 +71,7 @@ redef record Management::Request::Request += { }; # Tag our logs correctly -redef Management::Log::role = Management::CONTROLLER; +redef Management::role = Management::CONTROLLER; global check_instances_ready: function(); global add_instance: function(inst: Management::Instance); diff --git a/scripts/policy/frameworks/management/log.zeek b/scripts/policy/frameworks/management/log.zeek index 60c47ffdd2..a6f8d37571 100644 --- a/scripts/policy/frameworks/management/log.zeek +++ b/scripts/policy/frameworks/management/log.zeek @@ -3,7 +3,7 @@ ##! supervisor. In this setting Zeek's logging framework operates locally, i.e., ##! this does not involve logger nodes. -@load ./types +@load ./config module Management::Log; @@ -64,10 +64,6 @@ export { ## message: the message to log. ## global error: function(message: string); - - ## The role of this process in cluster management. Agent and controller - ## both redefine this, and we use it during logging. - const role = Management::NONE &redef; } # Enum translations to strings. This avoids those enums being reported @@ -93,7 +89,7 @@ function debug(message: string) local node = Supervisor::node(); Log::write(LOG, [$ts=network_time(), $node=node$name, $level=l2s[DEBUG], - $role=r2s[role], $message=message]); + $role=r2s[Management::role], $message=message]); } function info(message: string) @@ -103,7 +99,7 @@ function info(message: string) local node = Supervisor::node(); Log::write(LOG, [$ts=network_time(), $node=node$name, $level=l2s[INFO], - $role=r2s[role], $message=message]); + $role=r2s[Management::role], $message=message]); } function warning(message: string) @@ -113,7 +109,7 @@ function warning(message: string) local node = Supervisor::node(); Log::write(LOG, [$ts=network_time(), $node=node$name, $level=l2s[WARNING], - $role=r2s[role], $message=message]); + $role=r2s[Management::role], $message=message]); } function error(message: string) @@ -123,7 +119,7 @@ function error(message: string) local node = Supervisor::node(); Log::write(LOG, [$ts=network_time(), $node=node$name, $level=l2s[ERROR], - $role=r2s[role], $message=message]); + $role=r2s[Management::role], $message=message]); } event zeek_init() diff --git a/scripts/policy/frameworks/management/node/main.zeek b/scripts/policy/frameworks/management/node/main.zeek index 52aa5f1e96..c8649b6054 100644 --- a/scripts/policy/frameworks/management/node/main.zeek +++ b/scripts/policy/frameworks/management/node/main.zeek @@ -12,7 +12,7 @@ module Management::Node; # Tag our logs correctly -redef Management::Log::role = Management::NODE; +redef Management::role = Management::NODE; ## The type of dispatch callbacks. These implement a particular dispatch action, ## using the provided string vector as arguments, filling results into the