From bb8f102b2cb16f0c656bc50ed4a63fee72cf1216 Mon Sep 17 00:00:00 2001 From: Jon Siwek Date: Mon, 16 Sep 2013 16:10:49 -0500 Subject: [PATCH] Minor refactor to SSL BinPAC grammer. An unsized array already parses indefinitely. &until($element <= 0) just causes nonsense code to be generated. I.e. checking a pointer that can never even be null against <= 0. And the compare would happen after delete'ing the pointer, making it even odder (though still benign). --- src/analyzer/protocol/ssl/ssl-protocol.pac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/analyzer/protocol/ssl/ssl-protocol.pac b/src/analyzer/protocol/ssl/ssl-protocol.pac index b35d07f18b..41f5994072 100644 --- a/src/analyzer/protocol/ssl/ssl-protocol.pac +++ b/src/analyzer/protocol/ssl/ssl-protocol.pac @@ -667,7 +667,7 @@ type CiphertextRecord(rec: SSLRecord) = record { ###################################################################### type SSLPDU(is_orig: bool) = record { - records : SSLRecord(is_orig)[] &transient &until($element <= 0); + records : SSLRecord(is_orig)[] &transient; } &byteorder = bigendian;