From bdff2935a400b3fa68d2c32ff985b5416bd90c27 Mon Sep 17 00:00:00 2001 From: Arne Welzel Date: Wed, 6 Aug 2025 16:53:28 +0200 Subject: [PATCH] SessionAdapter: Keep tap_analyzers until destruction connection_state_remove() is invoked after Done(), so it's not a good idea to remove the tap analyzers before in case they have up-to-date information for the connection val. Relates to #4337 #4725 #4734 #4737 --- src/packet_analysis/protocol/ip/SessionAdapter.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/packet_analysis/protocol/ip/SessionAdapter.cc b/src/packet_analysis/protocol/ip/SessionAdapter.cc index 06188ec8d7..56b400f7d9 100644 --- a/src/packet_analysis/protocol/ip/SessionAdapter.cc +++ b/src/packet_analysis/protocol/ip/SessionAdapter.cc @@ -12,9 +12,6 @@ void SessionAdapter::Done() { Analyzer::Done(); for ( const auto& ta : tap_analyzers ) ta->Done(); - - // Ensure no more TapPacket() calls after Done() on TapAnalyzer instances. - tap_analyzers.clear(); } bool SessionAdapter::IsReuse(double t, const u_char* pkt) { return parent->IsReuse(t, pkt); }