From d23b15c08fd88ef2ac724b4fbafcb994281a09e1 Mon Sep 17 00:00:00 2001 From: Tim Wojtulewicz Date: Mon, 3 Feb 2020 17:23:31 -0500 Subject: [PATCH] Use std::move in a few places instead of copying a pass-by-value argument (performance-unnecessary-value-param) --- src/Reporter.cc | 2 +- src/RuleMatcher.cc | 2 +- src/broker/Manager.cc | 2 +- src/iosource/Packet.cc | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Reporter.cc b/src/Reporter.cc index 7b7b6a6675..94ba5302f3 100644 --- a/src/Reporter.cc +++ b/src/Reporter.cc @@ -255,7 +255,7 @@ public: using IPPair = std::pair; FlowWeirdTimer(double t, IPPair p, double timeout) - : Timer(t + timeout, TIMER_FLOW_WEIRD_EXPIRE), endpoints(p) + : Timer(t + timeout, TIMER_FLOW_WEIRD_EXPIRE), endpoints(std::move(p)) {} void Dispatch(double t, int is_expire) override diff --git a/src/RuleMatcher.cc b/src/RuleMatcher.cc index d6cdae8bd2..441e41a0b4 100644 --- a/src/RuleMatcher.cc +++ b/src/RuleMatcher.cc @@ -62,7 +62,7 @@ RuleHdrTest::RuleHdrTest(Prot arg_prot, Comp arg_comp, vector arg_v) size = 0; comp = arg_comp; vals = new maskedvalue_list; - prefix_vals = arg_v; + prefix_vals = std::move(arg_v); sibling = 0; child = 0; pattern_rules = 0; diff --git a/src/broker/Manager.cc b/src/broker/Manager.cc index 29564a386f..eae0ce723f 100644 --- a/src/broker/Manager.cc +++ b/src/broker/Manager.cc @@ -394,7 +394,7 @@ bool Manager::PublishEvent(string topic, RecordVal* args) xs.emplace_back(data_val->data); } - return PublishEvent(topic, event_name, std::move(xs)); + return PublishEvent(std::move(topic), event_name, std::move(xs)); } bool Manager::PublishIdentifier(std::string topic, std::string id) diff --git a/src/iosource/Packet.cc b/src/iosource/Packet.cc index 49d0cf35b0..0195f18be4 100644 --- a/src/iosource/Packet.cc +++ b/src/iosource/Packet.cc @@ -29,7 +29,7 @@ void Packet::Init(int arg_link_type, pkt_timeval *arg_ts, uint32_t arg_caplen, ts = *arg_ts; cap_len = arg_caplen; len = arg_len; - tag = arg_tag; + tag = std::move(arg_tag); copy = arg_copy;