From d6d56d330bb95e1d63e516c4d92f6dcd0ca5341f Mon Sep 17 00:00:00 2001
From: Tim Wojtulewicz <tim@corelight.com>
Date: Mon, 28 Apr 2025 15:07:48 -0700
Subject: [PATCH] script_opt: Add missing virtual destructor
 (cppcoreguidelines-virtual-class-destructor)

---
 .clang-tidy                       | 2 ++
 src/script_opt/CPP/RuntimeInits.h | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/.clang-tidy b/.clang-tidy
index c36e9db0e4..afe9219e49 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -2,6 +2,8 @@ Checks: [-*,
          bugprone-*,
          performance-*,
 
+         cppcoreguidelines-virtual-class-destructor,
+
          # Skipping these temporarily because they are very noisy
          -bugprone-narrowing-conversions,
          -bugprone-unchecked-optional-access,
diff --git a/src/script_opt/CPP/RuntimeInits.h b/src/script_opt/CPP/RuntimeInits.h
index b547097cb4..e582f0f492 100644
--- a/src/script_opt/CPP/RuntimeInits.h
+++ b/src/script_opt/CPP/RuntimeInits.h
@@ -174,6 +174,8 @@ public:
         inits_vec.resize(num_inits);
     }
 
+    virtual ~CPP_AbstractInits() = default;
+
     // Initialize the given cohort of elements.
     void InitializeCohort(InitsManager* im, int cohort) {
         // Get this object's vector-of-vector-of-indices.