From e54ea6d7e911097ca2e61202eadc346ffa30ace2 Mon Sep 17 00:00:00 2001 From: Jon Siwek Date: Thu, 29 Aug 2013 14:09:56 -0500 Subject: [PATCH] Fix mem leak in socks analyzer for bad addr types. --- src/analyzer/protocol/socks/socks-analyzer.pac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/analyzer/protocol/socks/socks-analyzer.pac b/src/analyzer/protocol/socks/socks-analyzer.pac index 80051f0b27..311ca852ee 100644 --- a/src/analyzer/protocol/socks/socks-analyzer.pac +++ b/src/analyzer/protocol/socks/socks-analyzer.pac @@ -85,8 +85,8 @@ refine connection SOCKS_Conn += { default: bro_analyzer()->ProtocolViolation(fmt("invalid SOCKSv5 addr type: %d", ${request.remote_name.addr_type})); + delete sa; return false; - break; } BifEvent::generate_socks_request(bro_analyzer(), @@ -124,8 +124,8 @@ refine connection SOCKS_Conn += { default: bro_analyzer()->ProtocolViolation(fmt("invalid SOCKSv5 addr type: %d", ${reply.bound.addr_type})); + delete sa; return false; - break; } BifEvent::generate_socks_reply(bro_analyzer(),