From edef3736fb2220d48a4db36e4027f5edd6a0760e Mon Sep 17 00:00:00 2001
From: Christian Kreibich <christian@corelight.com>
Date: Thu, 2 Jun 2022 22:50:43 -0700
Subject: [PATCH] Additional &is_used tags in the Netcontrol and Sumstats
 frameworks

When running a cluster, these functions only get called in select node types and
could trigger no-caller warnings on stderr.
---
 scripts/base/frameworks/netcontrol/main.zeek | 10 +++++-----
 scripts/base/frameworks/sumstats/main.zeek   |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/scripts/base/frameworks/netcontrol/main.zeek b/scripts/base/frameworks/netcontrol/main.zeek
index 9f9b0df9d4..44f3698eb0 100644
--- a/scripts/base/frameworks/netcontrol/main.zeek
+++ b/scripts/base/frameworks/netcontrol/main.zeek
@@ -889,7 +889,7 @@ function remove_rule_impl(id: string, reason: string) : bool
 	return success;
 	}
 
-function rule_expire_impl(r: Rule, p: PluginState) &priority=-5
+function rule_expire_impl(r: Rule, p: PluginState) &priority=-5 &is_used
 	{
 	# do not emit timeout events on shutdown
 	if ( zeek_is_terminating() )
@@ -913,7 +913,7 @@ function rule_expire_impl(r: Rule, p: PluginState) &priority=-5
 		event NetControl::rule_timeout(r, FlowInfo(), p); # timeout implementation will handle the removal
 	}
 
-function rule_added_impl(r: Rule, p: PluginState, exists: bool, msg: string &default="")
+function rule_added_impl(r: Rule, p: PluginState, exists: bool, msg: string &default="") &is_used
 	{
 	if ( r$id !in rules )
 		{
@@ -947,7 +947,7 @@ function rule_added_impl(r: Rule, p: PluginState, exists: bool, msg: string &def
 		}
 	}
 
-function rule_removed_impl(r: Rule, p: PluginState, msg: string &default="")
+function rule_removed_impl(r: Rule, p: PluginState, msg: string &default="") &is_used
 	{
 	if ( r$id !in rules )
 		{
@@ -973,7 +973,7 @@ function rule_removed_impl(r: Rule, p: PluginState, msg: string &default="")
 	rule_cleanup(rule);
 	}
 
-function rule_timeout_impl(r: Rule, i: FlowInfo, p: PluginState)
+function rule_timeout_impl(r: Rule, i: FlowInfo, p: PluginState) &is_used
 	{
 	if ( r$id !in rules )
 		{
@@ -1017,7 +1017,7 @@ function rule_timeout_impl(r: Rule, i: FlowInfo, p: PluginState)
 	rule_cleanup(rule);
 	}
 
-function rule_error_impl(r: Rule, p: PluginState, msg: string &default="")
+function rule_error_impl(r: Rule, p: PluginState, msg: string &default="") &is_used
 	{
 	if ( r$id !in rules )
 		{
diff --git a/scripts/base/frameworks/sumstats/main.zeek b/scripts/base/frameworks/sumstats/main.zeek
index feb8154ff3..5c82fe9212 100644
--- a/scripts/base/frameworks/sumstats/main.zeek
+++ b/scripts/base/frameworks/sumstats/main.zeek
@@ -548,7 +548,7 @@ function check_thresholds(ss: SumStat, key: Key, result: Result, modify_pct: dou
 	return F;
 	}
 
-function threshold_crossed(ss: SumStat, key: Key, result: Result)
+function threshold_crossed(ss: SumStat, key: Key, result: Result) &is_used
 	{
 	# If there is no callback, there is no point in any of this.
 	if ( ! ss?$threshold_crossed )