From fd11c63efe94ae6967bb7a31e03a7aea556d9686 Mon Sep 17 00:00:00 2001 From: Jon Siwek Date: Wed, 1 May 2019 22:55:43 -0700 Subject: [PATCH] Remove an unhelpful/optimistic DNS_Mgr optimization DNS_Mgr is always "idle", so Process() is always called when the fd signals there's really something ready (except when flushing at termination-time), so checking whether all pending request maps are empty within Process() doesn't help much. If they are empty, but there's somehow something to pull off the socket, the main loop is just going to keep trying to call Process() until it gets read (which would be bad if it's preventing another IOSource from getting real work done). --- src/DNS_Mgr.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/DNS_Mgr.cc b/src/DNS_Mgr.cc index db8100ca2b..4edff2088c 100644 --- a/src/DNS_Mgr.cc +++ b/src/DNS_Mgr.cc @@ -1418,9 +1418,6 @@ void DNS_Mgr::DoProcess() delete req; } - if ( asyncs_addrs.size() == 0 && asyncs_names.size() == 0 && asyncs_texts.size() == 0 ) - return; - if ( AnswerAvailable(0) <= 0 ) return;