Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 14:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix clang-tidy modernize-use-bool-literals findings

Browse source
This commit is contained in:
Tim Wojtulewicz 2025-06-04 12:20:14 -07:00
parent 17c14a3ce1
commit 0227e3a545
6 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

1
.clang-tidy
View file

@ -8,6 +8,7 @@ Checks: [-*,
modernize-pass-by-value, modernize-pass-by-value,
modernize-redundant-void-arg, modernize-redundant-void-arg,
modernize-return-braced-init-list, modernize-return-braced-init-list,
modernize-use-bool-literals,
# Enable a very limited number of the cppcoreguidelines checkers. # Enable a very limited number of the cppcoreguidelines checkers.
# See the notes for some of the rest of them below. # See the notes for some of the rest of them below.

2
src/analyzer/protocol/ftp/functions.bif
View file

@ -80,7 +80,7 @@ static zeek::RecordValPtr parse_eftp(const char* line)
std::string s(line, nptr-line); // extract IP address std::string s(line, nptr-line); // extract IP address
struct in6_addr result; struct in6_addr result;
good = zeek::IPAddr::ConvertString(s.c_str(), &result) ? 1 : 0; good = zeek::IPAddr::ConvertString(s.c_str(), &result);
if ( good ) if ( good )
addr = zeek::IPAddr(result); addr = zeek::IPAddr(result);
} }

2
src/analyzer/protocol/smb/smb1-com-negotiate.pac
View file

@ -147,7 +147,7 @@ refine connection SMB_Conn += {
type SMB_dialect = record { type SMB_dialect = record {
buffer_format : uint8; # must be 0x2 for dialect buffer_format : uint8; # must be 0x2 for dialect
name : SMB_string(0,0); name : SMB_string(false, 0);
}; };
type SMB1_negotiate_request(header: SMB_Header) = record { type SMB1_negotiate_request(header: SMB_Header) = record {

2
src/script_opt/ZAM/BuiltIn.cc
View file

@ -269,7 +269,7 @@ bool SortZBI::Build(ZAMCompiler* zam, const NameExpr* n, const ExprPList& args)
auto comp_func = comp_val->AsNameExpr(); auto comp_func = comp_val->AsNameExpr();
auto comp_type = comp_func->GetType()->AsFuncType(); auto comp_type = comp_func->GetType()->AsFuncType();
if ( comp_type->Yield()->Tag() != TYPE_INT || ! comp_type->ParamList()->AllMatch(elt_type, 0) || if ( comp_type->Yield()->Tag() != TYPE_INT || ! comp_type->ParamList()->AllMatch(elt_type, false) ||
comp_type->ParamList()->GetTypes().size() != 2 ) comp_type->ParamList()->GetTypes().size() != 2 )
return false; return false;

2
src/script_opt/ZAM/ZInst.cc
View file

@ -26,7 +26,7 @@ void ZInst::Dump(FILE* f, const string& prefix, const string& id1, const string&
const string& id4) const { const string& id4) const {
fprintf(f, "%s ", ZOP_name(op)); fprintf(f, "%s ", ZOP_name(op));
// fprintf(f, "(%s) ", op_type_name(op_type)); // fprintf(f, "(%s) ", op_type_name(op_type));
if ( t && 0 ) if ( t && false )
fprintf(f, "(%s) ", type_name(t->Tag())); fprintf(f, "(%s) ", type_name(t->Tag()));
switch ( op_type ) { switch ( op_type ) {

2
src/spicy/manager.cc
View file

@ -532,7 +532,7 @@ void Manager::analyzerError(file_analysis::Analyzer* a, const std::string& msg,
reporter->PopLocation(); reporter->PopLocation();
if ( a ) if ( a )
a->SetSkip(1); // Imitate what AnalyzerError() does for protocol analyzers. a->SetSkip(true); // Imitate what AnalyzerError() does for protocol analyzers.
} }
void Manager::analyzerError(packet_analysis::Analyzer* a, const std::string& msg, const std::string& location) { void Manager::analyzerError(packet_analysis::Analyzer* a, const std::string& msg, const std::string& location) {