Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 06:38:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

gen-zam: Use const references instead of copying type values

Browse source
This commit is contained in:
Tim Wojtulewicz 2025-06-09 18:01:12 -07:00
parent 97492b4d70
commit 027c075fb0
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tools/gen-zam/src/Gen-ZAM.cc
View file

@ -1996,7 +1996,7 @@ void ZAM_UnaryExprOpTemplate::BuildInstruction(const OCVec& oc,
{ {
type_src = constant_op ? "n" : "n1"; type_src = constant_op ? "n" : "n1";
Emit("auto " + type_src + " = flhs->GetOp1()->AsNameExpr();"); Emit("auto " + type_src + " = flhs->GetOp1()->AsNameExpr();");
Emit("auto t = flhs->GetType();"); Emit("const auto& t = flhs->GetType();");
} }
else else
@ -2005,7 +2005,7 @@ void ZAM_UnaryExprOpTemplate::BuildInstruction(const OCVec& oc,
type_src = constant_op ? "n" : "n1"; type_src = constant_op ? "n" : "n1";
auto type_suffix = zc == ZIC_VEC ? "->Yield();" : ";"; auto type_suffix = zc == ZIC_VEC ? "->Yield();" : ";";
Emit("auto t = " + type_src + "->GetType()" + type_suffix); Emit("const auto& t = " + type_src + "->GetType()" + type_suffix);
} }
BuildInstructionCore(params, suffix, zc); BuildInstructionCore(params, suffix, zc);
@ -2127,7 +2127,7 @@ void ZAM_BinaryExprOpTemplate::BuildInstruction(const OCVec& oc,
auto constant_op = oc[1] == ZAM_OC_CONSTANT; auto constant_op = oc[1] == ZAM_OC_CONSTANT;
string type_src = constant_op ? "c" : "n2"; string type_src = constant_op ? "c" : "n2";
auto type_suffix = zc == ZIC_VEC ? "->Yield();" : ";"; auto type_suffix = zc == ZIC_VEC ? "->Yield();" : ";";
Emit("auto t = " + type_src + "->GetType()" + type_suffix); Emit("const auto& t = " + type_src + "->GetType()" + type_suffix);
GenerateSecondTypeVars(oc, zc); GenerateSecondTypeVars(oc, zc);
BuildInstructionCore(params, suffix, zc); BuildInstructionCore(params, suffix, zc);
@ -2163,7 +2163,7 @@ void ZAM_BinaryExprOpTemplate::GenerateSecondTypeVars(const OCVec& oc,
type_src2 = "n3"; type_src2 = "n3";
} }
Emit("auto t2 = " + type_src2 + "->GetType()" + type_suffix); Emit("const auto& t2 = " + type_src2 + "->GetType()" + type_suffix);
Emit("auto tag2 = t2->Tag();"); Emit("auto tag2 = t2->Tag();");
Emit("auto i_t2 = t2->InternalType();"); Emit("auto i_t2 = t2->InternalType();");
} }
@ -2210,7 +2210,7 @@ void ZAM_RelationalExprOpTemplate::BuildInstruction(const OCVec& oc,
} }
auto type_suffix = zc == ZIC_VEC ? "->Yield();" : ";"; auto type_suffix = zc == ZIC_VEC ? "->Yield();" : ";";
Emit("auto t = " + op1 + "->GetType()" + type_suffix); Emit("const auto& t = " + op1 + "->GetType()" + type_suffix);
GenerateSecondTypeVars(oc, zc); GenerateSecondTypeVars(oc, zc);
BuildInstructionCore(params, suffix, zc); BuildInstructionCore(params, suffix, zc);