Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 14:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

deprecation messages for unused base script functions

Browse source
This commit is contained in:
Vern Paxson 2022-05-27 14:36:30 -07:00
parent a120bcd7d7
commit 07cf5cb089
9 changed files with 17 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

7
scripts/base/frameworks/intel/cluster.zeek
View file

@ -6,9 +6,10 @@
module Intel; module Intel;
# Internal events for cluster data distribution. # Internal events for cluster data distribution. Marked as &is_used since
global insert_item: event(item: Item); # they're communicated via Broker.
global insert_indicator: event(item: Item); global insert_item: event(item: Item) &is_used;
global insert_indicator: event(item: Item) &is_used;
# If this process is not a manager process, we don't want the full metadata. # If this process is not a manager process, we don't want the full metadata.
@if ( Cluster::local_node_type() != Cluster::MANAGER ) @if ( Cluster::local_node_type() != Cluster::MANAGER )

2
scripts/base/frameworks/notice/main.zeek
View file

@ -585,7 +585,7 @@ function is_being_suppressed(n: Notice::Info): bool
# Executes a script with all of the notice fields put into the # Executes a script with all of the notice fields put into the
# new process' environment as "ZEEK_ARG_<field>" variables. # new process' environment as "ZEEK_ARG_<field>" variables.
function execute_with_notice(cmd: string, n: Notice::Info) &deprecated function execute_with_notice(cmd: string, n: Notice::Info) &deprecated="Remove in v6.1. Usage testing indicates this function is unused."
{ {
# TODO: fix system calls # TODO: fix system calls
#local tgs = tags(n); #local tgs = tags(n);

2
scripts/base/frameworks/signatures/main.zeek
View file

@ -150,7 +150,7 @@ event zeek_init() &priority=5
# Returns true if the given signature has already been triggered for the given # Returns true if the given signature has already been triggered for the given
# [orig, resp] pair. # [orig, resp] pair.
function has_signature_matched(id: string, orig: addr, resp: addr): bool &deprecated function has_signature_matched(id: string, orig: addr, resp: addr): bool &deprecated="Remove in v6.1. Usage testing indicates this function is unused."
{ {
return [orig, resp] in vert_table ? id in vert_table[orig, resp] : F; return [orig, resp] in vert_table ? id in vert_table[orig, resp] : F;
} }

2
scripts/base/frameworks/software/main.zeek
View file

@ -454,7 +454,7 @@ function cmp_versions(v1: Version, v2: Version): int
return 0; return 0;
} }
function software_endpoint_name(id: conn_id, host: addr): string &deprecated function software_endpoint_name(id: conn_id, host: addr): string &deprecated="Remove in v6.1. Usage testing indicates this function is unused."
{ {
return fmt("%s %s", host, (host == id$orig_h ? "client" : "server")); return fmt("%s %s", host, (host == id$orig_h ? "client" : "server"));
} }

2
scripts/base/frameworks/sumstats/non-cluster.zeek
View file

@ -71,7 +71,7 @@ function data_added(ss: SumStat, key: Key, result: Result)
threshold_crossed(ss, key, result); threshold_crossed(ss, key, result);
} }
function request(ss_name: string): ResultTable &deprecated function request(ss_name: string): ResultTable &deprecated="Remove in v6.1. Usage testing indicates this function is unused."
{ {
# This only needs to be implemented this way for cluster compatibility. # This only needs to be implemented this way for cluster compatibility.
return when [ss_name] ( T ) return when [ss_name] ( T )

2
scripts/base/frameworks/sumstats/plugins/std-dev.zeek
View file

@ -23,7 +23,7 @@ function calc_std_dev(rv: ResultVal)
rv$std_dev = sqrt(rv$variance); rv$std_dev = sqrt(rv$variance);
} }
hook std_dev_hook(r: Reducer, val: double, obs: Observation, rv: ResultVal) &deprecated hook std_dev_hook(r: Reducer, val: double, obs: Observation, rv: ResultVal) &deprecated="Remove in v6.1. Usage testing indicates this function is unused."
{ {
calc_std_dev(rv); calc_std_dev(rv);
} }

2
scripts/base/protocols/ftp/utils-commands.zeek
View file

@ -133,7 +133,7 @@ function remove_pending_cmd(pc: PendingCmds, ca: CmdArg): bool
return F; return F;
} }
function pop_pending_cmd(pc: PendingCmds, reply_code: count, reply_msg: string): CmdArg &deprecated function pop_pending_cmd(pc: PendingCmds, reply_code: count, reply_msg: string): CmdArg &deprecated="Remove in v6.1. Usage testing indicates this function is unused."
{ {
local ca = get_pending_cmd(pc, reply_code, reply_msg); local ca = get_pending_cmd(pc, reply_code, reply_msg);
remove_pending_cmd(pc, ca); remove_pending_cmd(pc, ca);

8
scripts/base/protocols/radius/consts.zeek
View file

@ -182,7 +182,7 @@ const attr_types: table[count] of string = {
[171] = "Delegated-IPv6-Prefix-Pool", [171] = "Delegated-IPv6-Prefix-Pool",
[172] = "Stateful-IPv6-Address-Pool", [172] = "Stateful-IPv6-Address-Pool",
[173] = "IPv6-6rd-Configuration" [173] = "IPv6-6rd-Configuration"
} &default=function(i: count): string { return fmt("unknown-%d", i); } &deprecated; } &default=function(i: count): string { return fmt("unknown-%d", i); } &deprecated="Remove in v6.1. Usage testing indicates this function is unused.";
const nas_port_types: table[count] of string = { const nas_port_types: table[count] of string = {
[0] = "Async", [0] = "Async",
@ -205,7 +205,7 @@ const nas_port_types: table[count] of string = {
[17] = "Cable", [17] = "Cable",
[18] = "Wireless - Other", [18] = "Wireless - Other",
[19] = "Wireless - IEEE 802.11" [19] = "Wireless - IEEE 802.11"
} &default=function(i: count): string { return fmt("unknown-%d", i); } &deprecated; } &default=function(i: count): string { return fmt("unknown-%d", i); } &deprecated="Remove in v6.1. Usage testing indicates this function is unused.";
const service_types: table[count] of string = { const service_types: table[count] of string = {
[1] = "Login", [1] = "Login",
@ -219,7 +219,7 @@ const service_types: table[count] of string = {
[9] = "Callback NAS Prompt", [9] = "Callback NAS Prompt",
[10] = "Call Check", [10] = "Call Check",
[11] = "Callback Administrative", [11] = "Callback Administrative",
} &default=function(i: count): string { return fmt("unknown-%d", i); } &deprecated; } &default=function(i: count): string { return fmt("unknown-%d", i); } &deprecated="Remove in v6.1. Usage testing indicates this function is unused.";
const framed_protocol_types: table[count] of string = { const framed_protocol_types: table[count] of string = {
[1] = "PPP", [1] = "PPP",
@ -228,4 +228,4 @@ const framed_protocol_types: table[count] of string = {
[4] = "Gandalf proprietary SingleLink/MultiLink protocol", [4] = "Gandalf proprietary SingleLink/MultiLink protocol",
[5] = "Xylogics proprietary IPX/SLIP", [5] = "Xylogics proprietary IPX/SLIP",
[6] = "X.75 Synchronous" [6] = "X.75 Synchronous"
} &default=function(i: count): string { return fmt("unknown-%d", i); } &deprecated; } &default=function(i: count): string { return fmt("unknown-%d", i); } &deprecated="Remove in v6.1. Usage testing indicates this function is unused.";

6
scripts/base/protocols/smb/smb1-main.zeek
View file

@ -271,7 +271,7 @@ event smb1_write_andx_request(c: connection, hdr: SMB1::Header, file_id: count,
c$smb_state$pipe_map[file_id] = c$smb_state$current_file$uuid; c$smb_state$pipe_map[file_id] = c$smb_state$current_file$uuid;
} }
event smb_pipe_bind_ack_response(c: connection, hdr: SMB1::Header) &deprecated event smb_pipe_bind_ack_response(c: connection, hdr: SMB1::Header) &deprecated="Remove in v6.1. Usage testing indicates this function is unused."
{ {
if ( ! c$smb_state?$current_file || ! c$smb_state$current_file?$uuid ) if ( ! c$smb_state?$current_file || ! c$smb_state$current_file?$uuid )
{ {
@ -283,7 +283,7 @@ event smb_pipe_bind_ack_response(c: connection, hdr: SMB1::Header) &deprecated
c$smb_state$current_cmd$argument = SMB::rpc_uuids[c$smb_state$current_file$uuid]; c$smb_state$current_cmd$argument = SMB::rpc_uuids[c$smb_state$current_file$uuid];
} }
event smb_pipe_bind_request(c: connection, hdr: SMB1::Header, uuid: string, version: string) &deprecated event smb_pipe_bind_request(c: connection, hdr: SMB1::Header, uuid: string, version: string) &deprecated="Remove in v6.1. Usage testing indicates this function is unused."
{ {
if ( ! c$smb_state?$current_file || ! c$smb_state$current_file?$uuid ) if ( ! c$smb_state?$current_file || ! c$smb_state$current_file?$uuid )
{ {
@ -296,7 +296,7 @@ event smb_pipe_bind_request(c: connection, hdr: SMB1::Header, uuid: string, vers
c$smb_state$current_cmd$argument = fmt("%s v%s", SMB::rpc_uuids[uuid], version); c$smb_state$current_cmd$argument = fmt("%s v%s", SMB::rpc_uuids[uuid], version);
} }
event smb_pipe_request(c: connection, hdr: SMB1::Header, op_num: count) &deprecated event smb_pipe_request(c: connection, hdr: SMB1::Header, op_num: count) &deprecated="Remove in v6.1. Usage testing indicates this function is unused."
{ {
if ( ! c$smb_state?$current_file ) if ( ! c$smb_state?$current_file )
{ {