Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 14:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix for setting object locations to avoid use-after-free situation

Browse source
This commit is contained in:
Vern Paxson 2024-09-11 16:31:23 +02:00 • committed by Christian Kreibich
parent a68ffc5316
commit 07d211419a
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/Obj.cc
View file

@ -130,11 +130,14 @@ bool Obj::SetLocationInfo(const detail::Location* start, const detail::Location*
// We already have a better location, so don't use this one. // We already have a better location, so don't use this one.
return true; return true;
delete location; auto new_location =
location =
new detail::Location(start->filename, start->first_line, end->last_line, start->first_column, end->last_column); new detail::Location(start->filename, start->first_line, end->last_line, start->first_column, end->last_column);
// Don't delete this until we've constructed the new location, in case
// "start" or "end" are our own location.
delete location;
location = new_location;
return true; return true;
} }