Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 06:38:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge remote-tracking branch 'origin/topic/christian/fix-inputframework-test-race'

Browse source 
* origin/topic/christian/fix-inputframework-test-race:
  Fix race conditions in scripts.base.frameworks.input.reread
  Fix race condition in scripts.base.frameworks.input.invalid*
This commit is contained in:
Tim Wojtulewicz 2021-07-14 15:01:20 -07:00
commit 09c4908573
10 changed files with 783 additions and 1539 deletions
Download patch file Download diff file Expand all files Collapse all files

21
CHANGES
View file

@ -1,3 +1,24 @@
4.2.0-dev.14 | 2021-07-14 15:01:20 -0700
* Fix race conditions in scripts.base.frameworks.input.reread (Christian Kreibich, Corelight)
On FreeBSD, this test showed two problems: (1) reordering problems
based on writing the predicate, event, and end-of-data updates into a
single file, (2) a race condition based on printing the entirety of
the table description argument in update events. The description
contains the destination table, and its content at the time an update
event gets processed isn't deterministic: depending on the number
of updates the reader thread has sent, the table will contain a
varying number of entries.
* Fix race condition in scripts.base.frameworks.input.invalid* (Christian Kreibich, Corelight)
The invalidset and invalidtext tests loaded an input file via table
and event reads, in parallel. On FreeBSD this triggers an occasional
reordering of messages coming out of the reader thread vs the input
managers. This commit makes the table and event reads sequential,
avoiding the race.
4.2.0-dev.11 | 2021-07-14 15:00:11 -0700
* Reorder fields in some classes for more compact memory layout (Tim Wojtulewicz)