Remove unnecessary assert in ICMP analyzer (addresses #822).

Browse source

The ICMP/ICMPv6 analyzers function correctly when full packets have
not been captured, but everything up to and including the ICMP header
is there (e.g. the functions that inspect ICMP error message context
correctly check the caplen to see if more info can be extracted).

The "Should have been caught earlier already." comment may have referred
to NetSessions::CheckHeaderTrunc, which works as intended to catch cases
where the ICMP header is not there in full, but then the assert was
still not correctly formulated for that...

Also changed the ICMP checksum calculation to not occur when the full
packet has not been captured, which seems consistent with what the UDP
analysis does.

...

This commit is contained in:

Jon Siwek 2012-05-29 17:29:11 -05:00

parent 0c5afc59f7

commit 0aecca979e

5 changed files with 22 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

BIN

testing/btest/Traces/trunc/icmp-header-trunc.pcap Normal file

View file

Binary file not shown.