Merge remote-tracking branch 'origin/topic/timw/786-typecasting'

* origin/topic/timw/786-typecasting:
  GH-786: Move Type::As methods to cc file so they have type info for casting safely

CHANGES

@@ -1,4 +1,8 @@
 
+3.2.0-dev.830 | 2020-07-02 11:36:28 -0700
+
+  * GH-786: Move Type::As methods to cc file so they have type info for casting safely (Tim Wojtulewicz, Corelight)
+
 3.2.0-dev.828 | 2020-07-01 09:57:23 -0700
 
   * Fix a deprecation warning compiling with GCC (Jon Siwek, Corelight)

VERSION

@@ -1 +1 @@
-3.2.0-dev.828
+3.2.0-dev.830

src/Type.cc

@@ -71,6 +71,131 @@ Type::Type(zeek::TypeTag t, bool arg_base_type)
 	{
 	}
 
+#define CHECK_TYPE_TAG(tag_type, func_name) \
+	CHECK_TAG(tag, tag_type, func_name, type_name)
+
+const TypeList* Type::AsTypeList() const
+	{
+	CHECK_TYPE_TAG(TYPE_LIST, "Type::AsTypeList");
+	return (const TypeList*) this;
+	}
+
+TypeList* Type::AsTypeList()
+	{
+	CHECK_TYPE_TAG(TYPE_LIST, "Type::AsTypeList");
+	return (TypeList*) this;
+	}
+
+const TableType* Type::AsTableType() const
+	{
+	CHECK_TYPE_TAG(TYPE_TABLE, "Type::AsTableType");
+	return (const TableType*) this;
+	}
+
+TableType* Type::AsTableType()
+	{
+	CHECK_TYPE_TAG(TYPE_TABLE, "Type::AsTableType");
+	return (TableType*) this;
+	}
+
+const SetType* Type::AsSetType() const
+	{
+	if ( ! IsSet() )
+		BadTag("Type::AsSetType", type_name(tag));
+	return (const SetType*) this;
+	}
+
+SetType* Type::AsSetType()
+	{
+	if ( ! IsSet() )
+		BadTag("Type::AsSetType", type_name(tag));
+	return (SetType*) this;
+	}
+
+const RecordType* Type::AsRecordType() const
+	{
+	CHECK_TYPE_TAG(TYPE_RECORD, "Type::AsRecordType");
+	return (const RecordType*) this;
+	}
+
+RecordType* Type::AsRecordType()
+	{
+	CHECK_TYPE_TAG(TYPE_RECORD, "Type::AsRecordType");
+	return (RecordType*) this;
+	}
+
+const SubNetType* Type::AsSubNetType() const
+	{
+	CHECK_TYPE_TAG(TYPE_SUBNET, "Type::AsSubNetType");
+	return (const SubNetType*) this;
+	}
+
+SubNetType* Type::AsSubNetType()
+	{
+	CHECK_TYPE_TAG(TYPE_SUBNET, "Type::AsSubNetType");
+	return (SubNetType*) this;
+	}
+
+const FuncType* Type::AsFuncType() const
+	{
+	CHECK_TYPE_TAG(TYPE_FUNC, "Type::AsFuncType");
+	return (const FuncType*) this;
+	}
+
+FuncType* Type::AsFuncType()
+	{
+	CHECK_TYPE_TAG(TYPE_FUNC, "Type::AsFuncType");
+	return (FuncType*) this;
+	}
+
+const EnumType* Type::AsEnumType() const
+	{
+	CHECK_TYPE_TAG(TYPE_ENUM, "Type::AsEnumType");
+	return (const EnumType*) this;
+	}
+
+EnumType* Type::AsEnumType()
+	{
+	CHECK_TYPE_TAG(TYPE_ENUM, "Type::AsEnumType");
+	return (EnumType*) this;
+	}
+
+const VectorType* Type::AsVectorType() const
+	{
+	CHECK_TYPE_TAG(TYPE_VECTOR, "Type::AsVectorType");
+	return (const VectorType*) this;
+	}
+
+VectorType* Type::AsVectorType()
+	{
+	CHECK_TYPE_TAG(TYPE_VECTOR, "Type::AsVectorType");
+	return (VectorType*) this;
+	}
+
+const OpaqueType* Type::AsOpaqueType() const
+	{
+	CHECK_TYPE_TAG(TYPE_OPAQUE, "Type::AsOpaqueType");
+	return (const OpaqueType*) this;
+	}
+
+OpaqueType* Type::AsOpaqueType()
+	{
+	CHECK_TYPE_TAG(TYPE_OPAQUE, "Type::AsOpaqueType");
+	return (OpaqueType*) this;
+	}
+
+const TypeType* Type::AsTypeType() const
+	{
+	CHECK_TYPE_TAG(TYPE_TYPE, "Type::AsTypeType");
+	return (const TypeType*) this;
+	}
+
+TypeType* Type::AsTypeType()
+	{
+	CHECK_TYPE_TAG(TYPE_TYPE, "Type::AsTypeType");
+	return (TypeType*) this;
+	}
+
 IntrusivePtr<Type> Type::ShallowClone()
 	{
 	switch ( tag ) {

src/Type.h

@@ -194,126 +194,35 @@ public:
 	[[deprecated("Remove in v4.1.  Use RecordType::GetFieldType() directly.")]]
 	virtual Type* FieldType(const char* field) const;
 
-#define CHECK_TYPE_TAG(tag_type, func_name) \
+	const TypeList* AsTypeList() const;
-	CHECK_TAG(tag, tag_type, func_name, type_name)
+	TypeList* AsTypeList();
 
-	const TypeList* AsTypeList() const
+	const TableType* AsTableType() const;
-		{
+	TableType* AsTableType();
-		CHECK_TYPE_TAG(TYPE_LIST, "Type::AsTypeList");
-		return (const TypeList*) this;
-		}
-	TypeList* AsTypeList()
-		{
-		CHECK_TYPE_TAG(TYPE_LIST, "Type::AsTypeList");
-		return (TypeList*) this;
-		}
 
-	const TableType* AsTableType() const
+	const SetType* AsSetType() const;
-		{
+	SetType* AsSetType();
-		CHECK_TYPE_TAG(TYPE_TABLE, "Type::AsTableType");
-		return (const TableType*) this;
-		}
-	TableType* AsTableType()
-		{
-		CHECK_TYPE_TAG(TYPE_TABLE, "Type::AsTableType");
-		return (TableType*) this;
-		}
 
-	SetType* AsSetType()
+	const RecordType* AsRecordType() const;
-		{
+	RecordType* AsRecordType();
-		if ( ! IsSet() )
-			BadTag("Type::AsSetType", type_name(tag));
-		return (SetType*) this;
-		}
-	const SetType* AsSetType() const
-		{
-		if ( ! IsSet() )
-			BadTag("Type::AsSetType", type_name(tag));
-		return (const SetType*) this;
-		}
 
-	const RecordType* AsRecordType() const
+	const SubNetType* AsSubNetType() const;
-		{
+	SubNetType* AsSubNetType();
-		CHECK_TYPE_TAG(TYPE_RECORD, "Type::AsRecordType");
-		return (const RecordType*) this;
-		}
-	RecordType* AsRecordType()
-		{
-		CHECK_TYPE_TAG(TYPE_RECORD, "Type::AsRecordType");
-		return (RecordType*) this;
-		}
 
-	const SubNetType* AsSubNetType() const
+	const FuncType* AsFuncType() const;
-		{
+	FuncType* AsFuncType();
-		CHECK_TYPE_TAG(TYPE_SUBNET, "Type::AsSubNetType");
-		return (const SubNetType*) this;
-		}
 
-	SubNetType* AsSubNetType()
+	const EnumType* AsEnumType() const;
-		{
+	EnumType* AsEnumType();
-		CHECK_TYPE_TAG(TYPE_SUBNET, "Type::AsSubNetType");
-		return (SubNetType*) this;
-		}
 
-	const FuncType* AsFuncType() const
+	const VectorType* AsVectorType() const;
-		{
+	VectorType* AsVectorType();
-		CHECK_TYPE_TAG(TYPE_FUNC, "Type::AsFuncType");
-		return (const FuncType*) this;
-		}
 
-	FuncType* AsFuncType()
+	const OpaqueType* AsOpaqueType() const;
-		{
+	OpaqueType* AsOpaqueType();
-		CHECK_TYPE_TAG(TYPE_FUNC, "Type::AsFuncType");
-		return (FuncType*) this;
-		}
 
-	const EnumType* AsEnumType() const
+	const TypeType* AsTypeType() const;
-		{
+	TypeType* AsTypeType();
-		CHECK_TYPE_TAG(TYPE_ENUM, "Type::AsEnumType");
-		return (EnumType*) this;
-		}
-
-	EnumType* AsEnumType()
-		{
-		CHECK_TYPE_TAG(TYPE_ENUM, "Type::AsEnumType");
-		return (EnumType*) this;
-		}
-
-	const VectorType* AsVectorType() const
-		{
-		CHECK_TYPE_TAG(TYPE_VECTOR, "Type::AsVectorType");
-		return (VectorType*) this;
-		}
-
-	OpaqueType* AsOpaqueType()
-		{
-		CHECK_TYPE_TAG(TYPE_OPAQUE, "Type::AsOpaqueType");
-		return (OpaqueType*) this;
-		}
-
-	const OpaqueType* AsOpaqueType() const
-		{
-		CHECK_TYPE_TAG(TYPE_OPAQUE, "Type::AsOpaqueType");
-		return (OpaqueType*) this;
-		}
-
-	VectorType* AsVectorType()
-		{
-		CHECK_TYPE_TAG(TYPE_VECTOR, "Type::AsVectorType");
-		return (VectorType*) this;
-		}
-
-	const TypeType* AsTypeType() const
-		{
-		CHECK_TYPE_TAG(TYPE_TYPE, "Type::AsTypeType");
-		return (TypeType*) this;
-		}
-
-	TypeType* AsTypeType()
-		{
-		CHECK_TYPE_TAG(TYPE_TYPE, "Type::AsTypeType");
-		return (TypeType*) this;
-		}
 
 	bool IsSet() const
 		{