Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 14:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix clang-tidy performance-avoid-endl warnings

Browse source
This commit is contained in:
Tim Wojtulewicz 2025-04-25 13:41:30 -07:00
parent 10bfb34a8a
commit 11a1d8d506
3 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

1
.clang-tidy
View file

@ -1,5 +1,6 @@
Checks: [-*,
bugprone-*,
performance-avoid-endl,
# Skipping these temporarily because they are very noisy
-bugprone-narrowing-conversions,

15
src/logging/writers/none/None.cc
View file

@ -11,10 +11,10 @@ namespace zeek::logging::writer::detail {
bool None::DoInit(const WriterInfo& info, int num_fields, const threading::Field* const* fields) {
if ( BifConst::LogNone::debug ) {
std::cout << "[logging::writer::None]" << std::endl;
std::cout << " path=" << info.path << std::endl;
std::cout << " rotation_interval=" << info.rotation_interval << std::endl;
std::cout << " rotation_base=" << info.rotation_base << std::endl;
std::cout << "[logging::writer::None]\n";
std::cout << " path=" << info.path << "\n";
std::cout << " rotation_interval=" << info.rotation_interval << "\n";
std::cout << " rotation_base=" << info.rotation_base << "\n";
// Output the config sorted by keys.
@ -26,14 +26,15 @@ bool None::DoInit(const WriterInfo& info, int num_fields, const threading::Field
std::sort(keys.begin(), keys.end());
for ( std::vector<std::pair<std::string, std::string>>::const_iterator i = keys.begin(); i != keys.end(); i++ )
std::cout << " config[" << (*i).first << "] = " << (*i).second << std::endl;
std::cout << " config[" << (*i).first << "] = " << (*i).second << "\n";
for ( int i = 0; i < num_fields; i++ ) {
const threading::Field* field = fields[i];
std::cout << " field " << field->name << ": " << type_name(field->type) << std::endl;
std::cout << " field " << field->name << ": " << type_name(field->type) << "\n";
}
std::cout << std::endl;
std::cout << "\n";
std::cout << std::flush;
}
return true;

10
src/spicy/manager.cc
View file

@ -642,14 +642,12 @@ void Manager::InitPostScript() {
::hilti::rt::init();
::spicy::rt::init();
} catch ( const hilti::rt::Exception& e ) {
std::cerr << hilti::rt::fmt("uncaught runtime exception %s during initialization: %s",
hilti::rt::demangle(typeid(e).name()), e.what())
<< std::endl;
std::cerr << hilti::rt::fmt("uncaught runtime exception %s during initialization: %s\n",
hilti::rt::demangle(typeid(e).name()), e.what());
exit(1);
} catch ( const std::runtime_error& e ) {
std::cerr << hilti::rt::fmt("uncaught C++ exception %s during initialization: %s",
hilti::rt::demangle(typeid(e).name()), e.what())
<< std::endl;
std::cerr << hilti::rt::fmt("uncaught C++ exception %s during initialization: %s\n",
hilti::rt::demangle(typeid(e).name()), e.what());
exit(1);
}