Fix clang-tidy performance-move-const-argument warnings (moving const variables)

.clang-tidy

@@ -5,6 +5,7 @@ Checks: [-*,
          performance-faster-string-find,
          performance-for-range-copy,
          performance-inefficient-vector-operation,
+         performance-move-const-argument,
 
          # Skipping these temporarily because they are very noisy
          -bugprone-narrowing-conversions,

src/Reassem.cc

@@ -52,7 +52,7 @@ void DataBlockList::Delete(DataBlockMap::const_iterator it) {
 }
 
 DataBlock DataBlockList::Remove(DataBlockMap::const_iterator it) {
-    auto b = std::move(it->second);
+    auto b = it->second;
     auto size = b.Size();
 
     block_map.erase(it);

src/Type.cc

@@ -2348,7 +2348,7 @@ TypePtr merge_record_types(const Type* t1, const Type* t2) {
                 attrs3->AddAttrs(td2->attrs);
 
             attrs3->AddAttr(make_intrusive<detail::Attr>(detail::ATTR_OPTIONAL));
-            auto td_merge = new TypeDecl(util::copy_string(td2->id), std::move(td2->type), attrs3);
+            auto td_merge = new TypeDecl(util::copy_string(td2->id), td2->type, attrs3);
             tdl3->push_back(td_merge);
         }
     }

src/analyzer/protocol/ssl/SSL.cc

@@ -131,7 +131,7 @@ void SSL_Analyzer::SetKeys(const zeek::StringVal& nkeys) {
     std::copy(nkeys.Bytes(), nkeys.Bytes() + nkeys.Len(), std::back_inserter(keys));
 }
 
-void SSL_Analyzer::SetKeys(const std::vector<u_char> newkeys) { keys = std::move(newkeys); }
+void SSL_Analyzer::SetKeys(std::vector<u_char> newkeys) { keys = std::move(newkeys); }
 
 std::optional<std::vector<u_char>> SSL_Analyzer::TLS12_PRF(const std::string& secret, const std::string& label,
                                                            const std::string& rnd1, const std::string& rnd2,

src/analyzer/protocol/ssl/SSL.h

@@ -90,7 +90,7 @@ public:
      * @param keys The key buffer as derived via TLS PRF (for
      * AES_GCM this should be 72 bytes in length)
      */
-    void SetKeys(const std::vector<u_char> newkeys);
+    void SetKeys(std::vector<u_char> newkeys);
 
     /**
      * Check if the connection is flipped--meaning that the TLS client is the responder of the

src/broker/Data.cc

@@ -198,13 +198,13 @@ struct val_converter {
 
                     if ( disambiguate ) {
                         // Disambiguate from composite key w/ multiple vals.
-                        composite_key.emplace_back(std::move(item));
+                        composite_key.emplace_back(item);
                         indices = &composite_key;
                     }
                 }
             }
             else {
-                composite_key.emplace_back(std::move(item));
+                composite_key.emplace_back(item);
                 indices = &composite_key;
             }
 
@@ -247,13 +247,13 @@ struct val_converter {
 
                     if ( disambiguate ) {
                         // Disambiguate from composite key w/ multiple vals.
-                        composite_key.emplace_back(std::move(item.first));
+                        composite_key.emplace_back(item.first);
                         indices = &composite_key;
                     }
                 }
             }
             else {
-                composite_key.emplace_back(std::move(item.first));
+                composite_key.emplace_back(item.first);
                 indices = &composite_key;
             }
 
@@ -1036,7 +1036,7 @@ IMPLEMENT_OPAQUE_VALUE(zeek::Broker::detail::DataVal)
 std::optional<BrokerData> DataVal::DoSerializeData() const { return BrokerData{data}; }
 
 bool DataVal::DoUnserializeData(BrokerDataView dv) {
-    data = std::move(*dv.value_);
+    data = *dv.value_;
     return true;
 }
 

src/plugin/Manager.cc

@@ -317,7 +317,7 @@ void Manager::ActivateDynamicPlugin(const std::string& name) {
         UpdateInputFiles();
     else
         // Reschedule for another attempt later.
-        requested_plugins.insert(std::move(name));
+        requested_plugins.insert(name);
 }
 
 void Manager::ActivateDynamicPlugins(bool all) {

src/script_opt/IDOptInfo.cc

@@ -127,7 +127,7 @@ void IDOptInfo::DefinedAfter(const Stmt* s, const ExprPtr& e, const std::vector<
     // This needs to come after filling out the confluence
     // blocks, since they'll create their own (earlier) regions.
     usage_regions.emplace_back(s, true, stmt_num);
-    usage_regions.back().SetDefExpr(std::move(e));
+    usage_regions.back().SetDefExpr(e);
 
     if ( tracing )
         DumpBlocks();

src/zeek-setup.cc

@@ -711,7 +711,7 @@ SetupResult setup(int argc, char** argv, Options* zopts) {
     plugin_mgr->ExtendZeekPathForPlugins();
 
     for ( const auto& x : requested_plugins )
-        plugin_mgr->ActivateDynamicPlugin(std::move(x));
+        plugin_mgr->ActivateDynamicPlugin(x);
 
     plugin_mgr->ActivateDynamicPlugins(! options.bare_mode);