Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-04 07:38:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Avoid unary negation of INT64_MIN in modp_litoa10

Browse source 
Overlow can occur in that case, which is undefined behavior.
This commit is contained in:
Jon Siwek 2020-09-17 21:08:57 -07:00
parent d25ead8f8e
commit 17e3392052
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/modp_numtoa.c
View file

@ -57,7 +57,7 @@ void modp_uitoa10(uint32_t value, char* str)
void modp_litoa10(int64_t value, char* str) void modp_litoa10(int64_t value, char* str)
{ {
char* wstr=str; char* wstr=str;
uint64_t uvalue = (value < 0) ? -value : value; uint64_t uvalue = (value < 0) ? (value == INT64_MIN ? (uint64_t)(INT64_MAX) + 1 : -value) : value;
// Conversion. Number is reversed. // Conversion. Number is reversed.
do *wstr++ = (char)(48 + (uvalue % 10)); while(uvalue /= 10); do *wstr++ = (char)(48 + (uvalue % 10)); while(uvalue /= 10);