Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-04 23:58:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Add missing override specifier to a number of methods, remove virtual from some as well

Browse source
This commit is contained in:
Tim Wojtulewicz 2020-03-26 15:24:21 -07:00
parent 6aaabceed2
commit 186005133b
9 changed files with 42 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/logging/Manager.cc
View file

@ -1399,9 +1399,9 @@ public:
rotate = arg_rotate;
}
~RotationTimer();
~RotationTimer() override;
void Dispatch(double t, int is_expire);
void Dispatch(double t, int is_expire) override;
protected:
Manager::WriterInfo* winfo;

12
src/logging/WriterBackend.cc
View file

@ -25,13 +25,13 @@ public:
new_name(copy_string(new_name)), old_name(copy_string(old_name)), open(open),
close(close), success(success), terminating(terminating) { }
virtual ~RotationFinishedMessage()
~RotationFinishedMessage() override
{
delete [] new_name;
delete [] old_name;
}
virtual bool Process()
bool Process() override
{
return log_mgr->FinishedRotation(Object(), new_name, old_name, open, close, success, terminating);
}
@ -48,19 +48,19 @@ private:
class FlushWriteBufferMessage : public threading::OutputMessage<WriterFrontend>
{
public:
FlushWriteBufferMessage(WriterFrontend* writer)
FlushWriteBufferMessage(WriterFrontend* writer)
: threading::OutputMessage<WriterFrontend>("FlushWriteBuffer", writer) {}
virtual bool Process() { Object()->FlushWriteBuffer(); return true; }
bool Process() override { Object()->FlushWriteBuffer(); return true; }
};
class DisableMessage : public threading::OutputMessage<WriterFrontend>
{
public:
DisableMessage(WriterFrontend* writer)
DisableMessage(WriterFrontend* writer)
: threading::OutputMessage<WriterFrontend>("Disable", writer) {}
virtual bool Process() { Object()->SetDisable(); return true; }
bool Process() override { Object()->SetDisable(); return true; }
};
}

10
src/logging/WriterFrontend.cc
View file

@ -23,7 +23,7 @@ public:
{}
virtual bool Process() { return Object()->Init(num_fields, fields); }
bool Process() override { return Object()->Init(num_fields, fields); }
private:
const int num_fields;
@ -42,7 +42,7 @@ public:
virtual ~RotateMessage() { delete [] rotated_path; }
virtual bool Process() { return Object()->Rotate(rotated_path, open, close, terminating); }
bool Process() override { return Object()->Rotate(rotated_path, open, close, terminating); }
private:
WriterFrontend* frontend;
@ -59,7 +59,7 @@ public:
: threading::InputMessage<WriterBackend>("Write", backend),
num_fields(num_fields), num_writes(num_writes), vals(vals) {}
virtual bool Process() { return Object()->Write(num_fields, num_writes, vals); }
bool Process() override { return Object()->Write(num_fields, num_writes, vals); }
private:
int num_fields;
@ -74,7 +74,7 @@ public:
: threading::InputMessage<WriterBackend>("SetBuf", backend),
enabled(enabled) { }
virtual bool Process() { return Object()->SetBuf(enabled); }
bool Process() override { return Object()->SetBuf(enabled); }
private:
const bool enabled;
@ -87,7 +87,7 @@ public:
: threading::InputMessage<WriterBackend>("Flush", backend),
network_time(network_time) {}
virtual bool Process() { return Object()->Flush(network_time); }
bool Process() override { return Object()->Flush(network_time); }
private:
double network_time;
};