Merge remote-tracking branch 'origin/topic/awelzel/4573-remove-is-packet-source'

* origin/topic/awelzel/4573-remove-is-packet-source:
  IOSource: Remove IsPacketSource
This commit is contained in:
Arne Welzel 2025-06-17 09:25:30 +02:00
commit 19f2621f7b
4 changed files with 11 additions and 6 deletions

View file

@ -1,3 +1,10 @@
8.0.0-dev.435 | 2025-06-17 09:25:30 +0200
* GH-4573: IOSource: Remove IsPacketSource (Arne Welzel, Corelight)
This wasn't used in tree and even the PktSrc class doesn't override this
to return true, so just remove it outright without deprecation.
8.0.0-dev.433 | 2025-06-16 14:58:12 +0200
* btest/logging: Fly-by cleanup (Arne Welzel, Corelight)

3
NEWS
View file

@ -48,6 +48,9 @@ Breaking Changes
redef EventMetadata::add_missing_remote_network_timestamp = T;
- The ``IsPacketSource()`` method on ``IOSource`` was removed. It was unused
and incorrectly returned ``false`` on all packet sources.
New Functionality
-----------------

View file

@ -1 +1 @@
8.0.0-dev.433
8.0.0-dev.435

View file

@ -32,11 +32,6 @@ public:
*/
bool IsOpen() const { return ! closed; }
/**
* Returns true if this is a packet source.
*/
virtual bool IsPacketSource() const { return false; }
/**
* Initializes the source. Can be overwritten by derived classes.
*/